Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications refactoring #567

Merged
merged 8 commits into from
Sep 14, 2023
Merged

Notifications refactoring #567

merged 8 commits into from
Sep 14, 2023

Conversation

capital-G
Copy link
Member

Started some work on #565 which turned into its own PR (and is therefore based on that branch). Can be merged after #565 has been merged.

Simply a refactoring of the "who needs to tell who something was changed" for the graphql subscriptions, makes the code a a bit nicer.

Hopefully doesn't break something, but all tests are running.

@capital-G capital-G requested a review from vin-ni September 14, 2023 15:14
@github-actions
Copy link

File Coverage
All files 82%
gencaster/db_logging.py 96%
gencaster/distributor.py 68%
gencaster/schema.py 55%
gencaster/urls.py 76%
osc_server/models.py 91%
osc_server/server.py 55%
story_graph/engine.py 91%
story_graph/markdown_parser.py 91%
story_graph/models.py 97%
story_graph/types.py 93%
stream/frontend_types.py 94%
stream/models.py 92%
stream/types.py 99%

Minimum allowed coverage is 50%

Generated by 🐒 cobertura-action against bcb2443

Copy link
Member

@vin-ni vin-ni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@vin-ni vin-ni merged commit 90dee61 into main Sep 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants