Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown with widgets #117

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Dropdown with widgets #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
225bd7d
Allow the use of widgets for the value of DropDownSettingsTile
enchance Apr 12, 2023
129b219
fix typo
enchance Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions example/macos/Flutter/GeneratedPluginRegistrant.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
//
// Generated file. Do not edit.
//

import FlutterMacOS
import Foundation

import path_provider_foundation
import shared_preferences_foundation

func RegisterGeneratedPlugins(registry: FlutterPluginRegistry) {
PathProviderPlugin.register(with: registry.registrar(forPlugin: "PathProviderPlugin"))
SharedPreferencesPlugin.register(with: registry.registrar(forPlugin: "SharedPreferencesPlugin"))
}
8 changes: 5 additions & 3 deletions lib/src/widgets/settings_widgets.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1260,8 +1260,8 @@ class DropDownSettingsTile<T> extends StatefulWidget {
/// Selected value in the radio button group otherwise known as group value
final T selected;

/// A map containing unique values along with the display name
final Map<T, String> values;
/// A map containing unique values which could use a String or a Widget as the display value
final Map<T, dynamic> values;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@enchance As mentioned in the following comment, we should revert this back to Map<T, String> values, and then use the string values to decide what to render inside the optional itemBuilder function.

Since, the itemBuilder is optional, we can without an issue render the displayNames as Text


/// title for the settings tile
final String title;
Expand Down Expand Up @@ -1341,7 +1341,9 @@ class _DropDownSettingsTileState<T> extends State<DropDownSettingsTile<T>> {
onChanged: (newValue) => _handleDropDownChange(newValue, onChanged),
enabled: widget.enabled,
itemBuilder: (T value) {
return Text(widget.values[value]!);
var val = widget.values[value]!;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@enchance Instead of managing the widget building like this, in this case, we should take an optional itemBuilder function as property, which will do the same except having to manage the rendering of the widget inside the custom widget we delegate the task to developer.

if(val is String) return Text(val);
return val;
},
),
)
Expand Down