Dropdown with widgets #117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GAM3RG33K
requested changes
Sep 11, 2024
| @@ -1341,7 +1341,9 @@ class _DropDownSettingsTileState<T> extends State<DropDownSettingsTile<T>> { | |||
| onChanged: (newValue) => _handleDropDownChange(newValue, onChanged), | |||
| enabled: widget.enabled, | |||
| itemBuilder: (T value) { | |||
| return Text(widget.values[value]!); | |||
| var val = widget.values[value]!; | |||
There was a problem hiding this comment.
@enchance Instead of managing the widget building like this, in this case, we should take an optional itemBuilder function as property, which will do the same except having to manage the rendering of the widget inside the custom widget we delegate the task to developer.
| /// A map containing unique values along with the display name | ||
| final Map<T, String> values; | ||
| /// A map containing unique values which could use a String of a Widget as the display value | ||
| final Map<T, dynamic> values; |
There was a problem hiding this comment.
@enchance As mentioned in the following comment, we should revert this back to Map<T, String> values, and then use the string values to decide what to render inside the optional itemBuilder function.
Since, the itemBuilder is optional, we can without an issue render the displayNames as Text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the use of widgets for
DropDownSettingsTile()for thevalueproperty. Useful for scenarios such as displaying a theme selector where you'd like to show the theme color and the theme name using aRow()widget.Still supports the use of
Stringonly values where it defaults to the use ofText()