Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adding type checking #3046

Merged
merged 20 commits into from
Sep 3, 2024
Merged

chore: adding type checking #3046

merged 20 commits into from
Sep 3, 2024

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Aug 28, 2024 •
edited
Loading

Summary

  • Adds type checking across all our package test directories.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@petertonysmith94 petertonysmith94 added the chore Issue is a chore label Aug 28, 2024
@petertonysmith94 petertonysmith94 self-assigned this Aug 28, 2024
@vercel Vercel
Copy link

vercel bot commented Aug 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 2:38pm
fuels-ts ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 2:38pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 2:38pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Sep 3, 2024 2:38pm

@petertonysmith94 petertonysmith94 marked this pull request as ready for review August 28, 2024 11:52
Torres-ssf
Torres-ssf previously approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@Torres-ssf Torres-ssf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 👍

@petertonysmith94 petertonysmith94 marked this pull request as ready for review September 3, 2024 07:48
Torres-ssf
Torres-ssf previously approved these changes Sep 3, 2024
View reviewed changes
arboleya
arboleya previously approved these changes Sep 3, 2024
View reviewed changes
nedsalk
nedsalk previously approved these changes Sep 3, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Coverage Report:

Lines Branches Functions Statements
79.52%(+0%) 72.04%(+0%) 78.04%(+0%) 79.62%(+0%)
Changed Files:

Coverage values did not change👌.

@petertonysmith94 petertonysmith94 merged commit b41e959 into master Sep 3, 2024
23 checks passed
@petertonysmith94 petertonysmith94 deleted the ps/chore/adding-ts-checking branch September 3, 2024 15:18
@petertonysmith94 petertonysmith94 mentioned this pull request Oct 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@nedsalk nedsalk nedsalk approved these changes

@danielbate danielbate danielbate approved these changes

@arboleya arboleya arboleya approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

Assignees

@petertonysmith94 petertonysmith94

Labels
chore Issue is a chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate Why Test Files Are Being Ignored By Lint Script
6 participants
@petertonysmith94 @arboleya @danielbate @maschad @nedsalk @Torres-ssf