Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Altertype:check command #3248

Closed
petertonysmith94 opened this issue Oct 4, 2024 · 2 comments · Fixed by #3381
Closed

Altertype:check command #3248

petertonysmith94 opened this issue Oct 4, 2024 · 2 comments · Fixed by #3381
Labels
chore Issue is a chore good first issue Suitable for newcomers looking to contribute

Comments

@petertonysmith94
Copy link
Contributor

Summary

  • We currently do type:check in various hooks, which can slow down development, so we should move check to our lint hook.
  • Potentially the best strategy for this issue is to roll back the original PR, then re-add the checks to the related lint command.

All hooks
@petertonysmith94 petertonysmith94 added chore Issue is a chore good first issue Suitable for newcomers looking to contribute labels Oct 4, 2024
@petertonysmith94 petertonysmith94 changed the title Altertype:check in pretest Altertype:check command Oct 4, 2024
@YashSherla
Copy link

Can u assign me

@maschad
Copy link
Member

maschad commented Oct 9, 2024

Hey @YashSherla we appreciate your interest in this, if you would like to begin working on it feel free to but we prefer to only assign issues to contributors after they have opened a PR.

Rohit-Bhetal added a commit to Rohit-Bhetal/fuels-ts that referenced this issue Nov 11, 2024
@Rohit-Bhetal
refactor: move type:check to lint hook
62b5607 
- Removed type:check from pretest, build, and postbuild scripts
- Added type checking to lint command
- Improves development speed by reducing redundant type checks

Fixes FuelLabs#3248
@Rohit-Bhetal Rohit-Bhetal mentioned this issue Nov 11, 2024
Merged
4 tasks
Rohit-Bhetal added a commit to Rohit-Bhetal/fuels-ts that referenced this issue Nov 11, 2024
@Rohit-Bhetal
refactor: move type:check to lint hook- Removed type:check from prete…
4d67d8f 
…st, build, and postbuild scripts- Added type checking to lint command- Improves development speed by reducing redundant type checksFixes FuelLabs#3248
petertonysmith94 added a commit that referenced this issue Nov 20, 2024
@Rohit-Bhetal @maschad @petertonysmith94
chore: move type:check to lint hook (#3381)
30585c1 
* refactor: move type:check to lint hook

- Removed type:check from pretest, build, and postbuild scripts
- Added type checking to lint command
- Improves development speed by reducing redundant type checks

Fixes #3248

* refactor: move type:check to lint hook- Removed type:check from pretest, build, and postbuild scripts- Added type checking to lint command- Improves development speed by reducing redundant type checksFixes #3248

* Add type:check to turbo tasks and update root package.json lint script

* Add type:check to turbo tasks and update root package.json lint script

* chore: add changeset for type checking updates

* Update packages/create-fuels/package.json

Co-authored-by: Peter Smith <[email protected]>

* Update .changeset/polite-seas-taste.md

Co-authored-by: Peter Smith <[email protected]>

* Update packages/fuel-gauge/package.json

Co-authored-by: Peter Smith <[email protected]>

* Update packages/fuels/package.json

Co-authored-by: Peter Smith <[email protected]>

* Update internal/benchmarks/package.json

Co-authored-by: Peter Smith <[email protected]>

* Update package.json

Co-authored-by: Peter Smith <[email protected]>

* Update .changeset/polite-seas-taste.md

Co-authored-by: Peter Smith <[email protected]>

* Update apps/docs-snippets/package.json

Co-authored-by: Peter Smith <[email protected]>

---------

Co-authored-by: Chad Nehemiah <[email protected]>
Co-authored-by: Peter Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Issue is a chore good first issue Suitable for newcomers looking to contribute
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: move type:check to lint hook Rohit-Bhetal/fuels-ts
3 participants
@maschad @petertonysmith94 @YashSherla