-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kernel Version Check #1117
Add Kernel Version Check #1117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -148,6 +148,10 @@ | |||
|
|||
/*---------------------------------------------------------------------------*/ | |||
|
|||
#if ( ( tskKERNEL_VERSION_MAJOR < 8 ) || ( ( tskKERNEL_VERSION_MAJOR == 8 ) && ( tskKERNEL_VERSION_MINOR < 1 ) ) ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose that this specific version is used due to the fact that before this pdMS_TO_TICKS
did not exist which is used a lot in this library.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's actually from this but looking at the changelog myself I think maybe it should be v8.2 cause that's when task notifications were added. I can try and at least see the oldest version that will compile later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! That would be great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Task notifications are used by the IP stack only if ipconfigSELECT_USES_NOTIFY
is enabled. Network interfaces might still use it, depending on how the EMAC task is implemented.
@ActoryOu should we be including the kernel headers here FreeRTOS-Plus-TCP/test/build-combination/Header_Self_Contain/headerSelfContain.cmake Line 21 in df5aed9
|
Sorry for late response. |
Thanks for this PR. But to me, it seems like the kernel version check is not adding much value here, as without the check as well, the compilation should fail if the user is not using the right kernel version. Another reason is that, though event groups are added with kernel version v8.1, task notifications (which were added with v8.2) could be used in the network interface or with |
@tony-josi-aws to your first point, the value would be in making it obvious to users why it is not compiling, instead of getting more questions on the forum. To the second point, the check is currently for v8.1, not v8.2. |
Adds a check for minimum supported kernel version