Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kernel Version Check #1117

Closed
wants to merge 5 commits into from
Closed

Add Kernel Version Check #1117

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
62dcb45
Add Kernel Version Check
HTRamsey Mar 14, 2024
68743bf
Merge branch 'main' into dev-kernel-version
tony-josi-aws Mar 15, 2024
8ab8e88
Merge branch 'main' into dev-kernel-version
HTRamsey Mar 20, 2024
fbe766e
Merge branch 'main' into dev-kernel-version
tony-josi-aws Mar 25, 2024
3120d7e
Merge branch 'main' into dev-kernel-version
tony-josi-aws Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions source/include/FreeRTOSIPConfigDefaults.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,10 @@

/*---------------------------------------------------------------------------*/

#if ( ( tskKERNEL_VERSION_MAJOR < 8 ) || ( ( tskKERNEL_VERSION_MAJOR == 8 ) && ( tskKERNEL_VERSION_MINOR < 1 ) ) )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose that this specific version is used due to the fact that before this pdMS_TO_TICKS did not exist which is used a lot in this library.

Copy link
Contributor Author

@HTRamsey HTRamsey Mar 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually from this but looking at the changelog myself I think maybe it should be v8.2 cause that's when task notifications were added. I can try and at least see the oldest version that will compile later.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! That would be great.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HTRamsey

Task notifications are used by the IP stack only if ipconfigSELECT_USES_NOTIFY is enabled. Network interfaces might still use it, depending on how the EMAC task is implemented.

#error Kernel version must be at least v8.1
#endif

/*
* pdFREERTOS_ERRNO_EAFNOSUPPORT
*
Expand Down
Loading