Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Silently handle request response miss-matches #235

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Jul 3, 2024

The SDK ignores responses that have come from an identity that has since changed. This was causing uncaught errors upstream. This PR adjusts the SDK to silently handle the errors, they will still be logged if enableLogs is true.

The easiest way to replicate this is by identifying multiple times with network throttling.

@kyle-ssg kyle-ssg merged commit 6e9d037 into main Jul 3, 2024
1 check passed
@kyle-ssg kyle-ssg deleted the fix/concurrent-identity-requests branch July 3, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants