Merge pull request #235 from Flagsmith/fix/concurrent-identity-requests

fix: Silently handle request response miss-matches
Flagsmith · Jul 3, 2024 · 6e9d037 · 6e9d037
2 parents 1a47754 + 8f9c0c8
commit 6e9d037
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 5 deletions.
diff --git a/flagsmith-core.ts b/flagsmith-core.ts
@@ -85,7 +85,11 @@ const Flagsmith = class {
                 isFetching: true
             })
         }
-        const handleResponse = ({ flags: features, traits }: IFlagsmithResponse) => {
+        const handleResponse = (response: IFlagsmithResponse | null) => {
+            if(!response) {
+                return // getJSON returned null due to request/response mismatch
+            }
+            let { flags: features, traits }: IFlagsmithResponse = response
             this.isLoading = false;
             if (identity) {
                 this.withTraits = null;
@@ -188,7 +192,7 @@ const Flagsmith = class {
             ])
                 .then((res) => {
                     this.withTraits = null
-                    return handleResponse(res[0] as IFlagsmithResponse)
+                    return handleResponse(res?.[0] as IFlagsmithResponse | null)
                 }).catch(({ message }) => {
                     const error = new Error(message)
                     return Promise.reject(error)

diff --git a/lib/flagsmith-es/package.json b/lib/flagsmith-es/package.json
@@ -1,6 +1,6 @@
 {
   "name": "flagsmith-es",
-  "version": "4.0.2",
+  "version": "4.0.3",
   "description": "Feature flagging to support continuous development. This is an esm equivalent of the standard flagsmith npm module.",
   "main": "./index.js",
   "type": "module",

diff --git a/lib/flagsmith/package.json b/lib/flagsmith/package.json
@@ -1,6 +1,6 @@
 {
   "name": "flagsmith",
-  "version": "4.0.2",
+  "version": "4.0.3",
   "description": "Feature flagging to support continuous development",
   "main": "./index.js",
   "repository": {

diff --git a/lib/react-native-flagsmith/package.json b/lib/react-native-flagsmith/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-native-flagsmith",
-  "version": "4.0.2",
+  "version": "4.0.3",
   "description": "Feature flagging to support continuous development",
   "main": "./index.js",
   "repository": {