fix: remove visual discrepancies after updating o-table to new button designs #1914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frshwtr
requested review from
ft-dependency-auto-merger and
a team
as code owners
frshwtr
force-pushed
the
2025-release-align-o-table-buttons
branch
from
023618a to
8d4af26
Compare
notlee
reviewed
Jan 6, 2025
| @@ -13,7 +13,7 @@ | |||
| "core/components/o3-editorial-typography": "source", | |||
| "core/components/o3-form/use-case": "source", | |||
| "core/components/o3-form": "source", | |||
| "core/base/border-radius": "source", | |||
| "core/base/border-radius": "enabled", | |||
There was a problem hiding this comment.
Let Mary/Deyan know you're doing this in the internal channel. Decide if it should be published in Figma. I would expect that it would, as other designs may want to match the radius in other design elements
notlee
requested changes
Jan 6, 2025
notlee
approved these changes
Jan 7, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Link to Figma designs
Checklist before requesting a review
percylabel for o-[COMPONENT] orchromaticlabel for o3-[COMPONENT] on my PR before merging and after review. Find more details in CONTRIBUTING.md