Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce rounded borders to buttons #1912

Closed
wants to merge 9 commits into from

Conversation

frshwtr
Copy link
Contributor

@frshwtr frshwtr commented Jan 2, 2025

Describe your changes

Issue ticket number and link

Link to Figma designs

Checklist before requesting a review

  • I have applied percy label for o-[COMPONENT] or chromatic label for o3-[COMPONENT] on my PR before merging and after review. Find more details in CONTRIBUTING.md
  • If it is a new feature, I have added thorough tests.
  • I have updated relevant docs.
  • I have updated relevant env variables in Doppler.

@notlee notlee temporarily deployed to origami-webs-2025-relea-omazxz January 2, 2025 14:56 Inactive
@notlee notlee temporarily deployed to origami-webs-2025-relea-omazxz January 3, 2025 11:25 Inactive
@notlee
Copy link
Contributor

notlee commented Jan 3, 2025

Box radio buttons: Remove border between items and add radius to container.

Mary's requested we add a radius and her designs are like this (I assume the last image is what we have today)
Screenshot 2025-01-03 at 17 38 46

However the PR currently looks boxy:

Screenshot 2025-01-03 at 17 39 00

@notlee
Copy link
Contributor

notlee commented Jan 3, 2025

Social sign-in: This should also increase to 44px

@notlee notlee self-requested a review January 3, 2025 17:49
Copy link
Contributor

@notlee notlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments above:

  • Discrepancies in box radio design / implementation
  • Missing height increase on social sign in buttons

Everything looks good 👍

@notlee
Copy link
Contributor

notlee commented Jan 7, 2025

Closing in favour of #1914

@notlee notlee closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants