Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid name conflict with BaseSection classes #453

Merged
merged 11 commits into from
Oct 18, 2024

Conversation

lukaspie
Copy link
Collaborator

No description provided.

@lukaspie lukaspie changed the base branch from master to replace_BasicEln October 18, 2024 07:45
@lukaspie lukaspie force-pushed the avoid-name-conflict branch from 3be258e to 6e34ffd Compare October 18, 2024 08:45
@lukaspie lukaspie changed the base branch from replace_BasicEln to master October 18, 2024 09:24
@lukaspie lukaspie marked this pull request as ready for review October 18, 2024 09:46
@lukaspie lukaspie changed the base branch from master to replace_BasicEln October 18, 2024 09:49
@lukaspie lukaspie changed the title Avoid name conflict with BaseSection class Avoid name conflict with BaseSection classes Oct 18, 2024
@@ -36,7 +36,7 @@ jobs:
- name: Install nomad
if: "${{ matrix.python_version != '3.8' && matrix.python_version != '3.12'}}"
run: |
uv pip install nomad-lab@git+https://gitlab.mpcdf.mpg.de/nomad-lab/nomad-FAIR.git
uv pip install git+https://gitlab.mpcdf.mpg.de/nomad-lab/nomad-FAIR.git@fixes_resolve_variadic_name
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be changed back later.

Copy link
Collaborator

@sanbrock sanbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukaspie lukaspie merged commit a287b39 into replace_BasicEln Oct 18, 2024
14 checks passed
@lukaspie lukaspie deleted the avoid-name-conflict branch October 18, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants