Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(expressions): Extend Expression.url.upload() to support row-specific URLs #3518

Merged
merged 3 commits into from
Dec 21, 2024
+283 −67

Impl

5badcb4
Select commit
Loading
Failed to load commit list.
Merged

feat(expressions): Extend Expression.url.upload() to support row-specific URLs #3518

Impl
5badcb4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Dec 17, 2024 in 0s

79.16% of diff hit (target 77.60%)

View this Pull Request on Codecov

79.16% of diff hit (target 77.60%)

Annotations

Check warning on line 1417 in daft/expressions/expressions.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/expressions/expressions.py#L1417 

Added line #L1417 was not covered by tests

Check warning on line 51 in src/daft-functions/src/uri/upload.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-functions/src/uri/upload.rs#L51 

Added line #L51 was not covered by tests

Check warning on line 64 in src/daft-functions/src/uri/upload.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-functions/src/uri/upload.rs#L64 

Added line #L64 was not covered by tests

Check warning on line 70 in src/daft-functions/src/uri/upload.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-functions/src/uri/upload.rs#L67-L70 

Added lines #L67 - L70 were not covered by tests

Check warning on line 75 in src/daft-functions/src/uri/upload.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-functions/src/uri/upload.rs#L75 

Added line #L75 was not covered by tests

Check warning on line 98 in src/daft-functions/src/uri/upload.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-functions/src/uri/upload.rs#L98 

Added line #L98 was not covered by tests

Check warning on line 107 in src/daft-functions/src/uri/upload.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-functions/src/uri/upload.rs#L104-L107 

Added lines #L104 - L107 were not covered by tests

Check warning on line 109 in src/daft-functions/src/uri/upload.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-functions/src/uri/upload.rs#L109 

Added line #L109 was not covered by tests

Check warning on line 120 in src/daft-functions/src/uri/upload.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-functions/src/uri/upload.rs#L117-L120 

Added lines #L117 - L120 were not covered by tests

Check warning on line 124 in src/daft-functions/src/uri/upload.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-functions/src/uri/upload.rs#L123-L124 

Added lines #L123 - L124 were not covered by tests

Check warning on line 126 in src/daft-functions/src/uri/upload.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-functions/src/uri/upload.rs#L126 

Added line #L126 was not covered by tests

Check warning on line 228 in src/daft-functions/src/uri/upload.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-functions/src/uri/upload.rs#L228 

Added line #L228 was not covered by tests

Check warning on line 281 in src/daft-functions/src/uri/upload.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-functions/src/uri/upload.rs#L281 

Added line #L281 was not covered by tests

Check warning on line 284 in src/daft-functions/src/uri/upload.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-functions/src/uri/upload.rs#L284 

Added line #L284 was not covered by tests

Check warning on line 286 in src/daft-functions/src/uri/upload.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-functions/src/uri/upload.rs#L286 

Added line #L286 was not covered by tests

Check warning on line 300 in src/daft-functions/src/uri/upload.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-functions/src/uri/upload.rs#L300 

Added line #L300 was not covered by tests

Check warning on line 303 in src/daft-functions/src/uri/upload.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-functions/src/uri/upload.rs#L303 

Added line #L303 was not covered by tests

Check warning on line 305 in src/daft-functions/src/uri/upload.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-functions/src/uri/upload.rs#L305 

Added line #L305 was not covered by tests

Check warning on line 320 in src/daft-io/src/lib.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-io/src/lib.rs#L320 

Added line #L320 was not covered by tests

Check warning on line 352 in src/daft-io/src/lib.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-io/src/lib.rs#L352 

Added line #L352 was not covered by tests
View more details on Codecov