-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(expressions): Extend Expression.url.upload() to support row-specific URLs #3518
feat(expressions): Extend Expression.url.upload() to support row-specific URLs #3518
Conversation
CodSpeed Performance ReportMerging #3518 will improve performances by 56.52%Comparing Summary
Benchmarks breakdown
|
cae7581
to
c12cf8e
Compare
c12cf8e
to
5badcb4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3518 +/- ##
==========================================
+ Coverage 77.60% 77.91% +0.31%
==========================================
Files 708 719 +11
Lines 86156 88516 +2360
==========================================
+ Hits 66858 68966 +2108
- Misses 19298 19550 +252
|
@raunakab assigning you for review since you're oncall :) |
Perfect! Will take a look through. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few questions.
Addresses #3320
Expression.url.upload()
can now take in a column of urls to upload each row to a specific url.