Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fixes regexp_replace expression #3306

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

ConeyLiu
Copy link
Contributor

regexp_replace should set regex to True

@github-actions github-actions bot added the bug Something isn't working label Nov 16, 2024
Copy link

codspeed-hq bot commented Nov 16, 2024

CodSpeed Performance Report

Merging #3306 will degrade performances by 17.6%

Comparing ConeyLiu:fixes-regexp-replace (71991af) with main (84db665)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 14 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main ConeyLiu:fixes-regexp-replace Change
test_count[1 Small File] 3.3 ms 4 ms -17.6%
test_iter_rows_first_row[100 Small Files] 421.4 ms 293 ms +43.83%
test_show[100 Small Files] 32.7 ms 24 ms +36.04%

@universalmind303 universalmind303 merged commit 824df2c into Eventual-Inc:main Nov 19, 2024
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants