[BUG] Fixes regexp_replace expression (#3306)

`regexp_replace` should set regex to True
Eventual-Inc · Nov 19, 2024 · 824df2c · 824df2c
1 parent 274f300
commit 824df2c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/daft-sql/src/modules/utf8.rs b/src/daft-sql/src/modules/utf8.rs
@@ -233,7 +233,7 @@ utf8_function!(
 utf8_function!(
     SQLUtf8RegexpReplace,
     "regexp_replace",
-    |input, pattern, replacement| daft_functions::utf8::replace(input, pattern, replacement, false),
+    |input, pattern, replacement| daft_functions::utf8::replace(input, pattern, replacement, true),
     "Replaces all occurrences of a substring with a new string",
     "string_input",
     "pattern",

diff --git a/tests/sql/test_utf8_exprs.py b/tests/sql/test_utf8_exprs.py
@@ -78,7 +78,7 @@ def test_utf8_exprs():
             col("a").str.extract("ba.").alias("extract_a"),
             col("a").str.extract_all("ba.").alias("extract_all_a"),
             col("a").str.split(r"\s+", regex=True).alias("regexp_split_a"),
-            col("a").str.replace("ba.", "foo").alias("replace_a"),
+            col("a").str.replace("ba.", "foo", regex=True).alias("replace_a"),
             col("a").str.length().alias("length_a"),
             col("a").str.length_bytes().alias("length_bytes_a"),
             col("a").str.lower().alias("lower_a"),