Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add ceil function #1867

Merged
merged 1 commit into from
Feb 11, 2024
Merged

Conversation

NormallyGaussian
Copy link
Contributor

Adding the ceil function to match https://ibis-project.org/reference/expression-numeric#ibis.expr.types.numeric.NumericValue.ceil. Added tests with example usage.

This is my first PR here. Happy to take on more of the functions in #1037 after getting through this one.

Copy link

codecov bot commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9b6cb94) 85.52% compared to head (1d1076e) 85.54%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1867      +/-   ##
==========================================
+ Coverage   85.52%   85.54%   +0.01%     
==========================================
  Files          55       55              
  Lines        6185     6190       +5     
==========================================
+ Hits         5290     5295       +5     
  Misses        895      895              
Files Coverage Δ
daft/expressions/expressions.py 90.93% <100.00%> (+0.06%) ⬆️
daft/series.py 92.87% <100.00%> (+0.03%) ⬆️

@NormallyGaussian NormallyGaussian marked this pull request as ready for review February 11, 2024 21:28
Copy link
Member

@samster25 samster25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on your first contribution! And wow, this looks perfect! I don't have any feedback to give! This should go out in tomorrow's release.

Also we would love if you could contribute more from the ibis list!

@samster25 samster25 changed the title Add ceil function [FEAT] Add ceil function Feb 11, 2024
@samster25 samster25 merged commit 05e3e3f into Eventual-Inc:main Feb 11, 2024
39 of 41 checks passed
@jaychia jaychia mentioned this pull request Feb 12, 2024
36 tasks
@samster25 samster25 mentioned this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants