Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Expressions from Ibis #1037

Closed
36 tasks done
jaychia opened this issue Jun 12, 2023 · 6 comments
Closed
36 tasks done

Add Expressions from Ibis #1037

jaychia opened this issue Jun 12, 2023 · 6 comments
Labels
enhancement New feature or request expression A new expression

Comments

@jaychia
Copy link
Contributor

jaychia commented Jun 12, 2023 •
edited by colin-ho
Loading

Is your feature request related to a problem? Please describe.

We would like to add more expressions and kernels for functionality to eventually have parity with Ibis (https://ibis-project.org/reference/expression-numeric).

Generic

https://ibis-project.org/reference/expression-generic

Numeric

https://ibis-project.org/reference/expression-numeric

Strings

Single-argument kernels:

Multi-argument kernels:
@jaychia jaychia added the enhancement New feature or request label Jun 12, 2023
@shril
Copy link

shril commented Jun 13, 2023

Taking care of this issue.

@jaychia jaychia added the expression A new expression label Sep 25, 2023
@jaychia jaychia added the good first issue Good for newcomers label Oct 24, 2023
@jaychia jaychia added this to Daft-OSS Jan 8, 2024
@github-project-automation github-project-automation bot moved this to On Deck in Daft-OSS Jan 8, 2024
@jaychia jaychia moved this from On Deck to Traige in Daft-OSS Jan 10, 2024
@jaychia jaychia changed the title String Kernels Add Expressions from Ibis Jan 22, 2024
@NormallyGaussian NormallyGaussian mentioned this issue Feb 11, 2024
Merged
samster25 pushed a commit that referenced this issue Feb 11, 2024
@NormallyGaussian
[FEAT] Add ceil function (#1867)
05e3e3f 
Adding the `ceil` function to match
https://ibis-project.org/reference/expression-numeric#ibis.expr.types.numeric.NumericValue.ceil.
Added tests with example usage.

This is my first PR here. Happy to take on more of the functions in
#1037 after getting through this one.
@jaychia
Copy link
Contributor Author

jaychia commented Feb 12, 2024

Thanks @NormallyGaussian for ceil #1867 !

@nsalerni
Copy link
Contributor

Would like to take care of a few of these as an intro to this repo !

@jaychia
Copy link
Contributor Author

jaychia commented Feb 20, 2024

Would like to take care of a few of these as an intro to this repo !

Yes, some of the string functionality should be a pretty good introduction! Just make sure to comment in this PR which functions you are taking to avoid duplicate with :)

Here's a really awesome PR to show you how to get started: #1867

@nsalerni
Copy link
Contributor

Thanks @jaychia ! I will take the single-argument string kernels to start:

  • .str.capitalize()
  • .str.upper()
  • .str.lower()
  • .str.lstrip()
  • .str.rstrip()
  • .str.reverse()

@colin-ho
Copy link
Contributor

Exploded all the checkboxes into individual issues so they can be assigned and tracked better.

@colin-ho colin-ho removed the good first issue Good for newcomers label May 28, 2024
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Daft-OSS May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request expression A new expression
Projects
No open projects
Daft-OSS
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nsalerni @shril @jaychia @colin-ho