Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Improve error messages when calling aggregation methods on dataframe without input columns #1587

Merged
merged 5 commits into from
Nov 13, 2023

modify other agg methods

c038678
Select commit
Loading
Failed to load commit list.
Merged

[CHORE] Improve error messages when calling aggregation methods on dataframe without input columns #1587

modify other agg methods
c038678
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 13, 2023 in 0s

85.04% (+0.14%) compared to 96b73d6

View this Pull Request on Codecov

85.04% (+0.14%) compared to 96b73d6

Details

Codecov Report

Merging #1587 (c038678) into main (96b73d6) will increase coverage by 0.14%.
Report is 7 commits behind head on main.
The diff coverage is 34.78%.

❗ Current head c038678 differs from pull request most recent head 5c787ae. Consider uploading reports for the commit 5c787ae to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1587      +/-   ##
==========================================
+ Coverage   84.90%   85.04%   +0.14%     
==========================================
  Files          54       54              
  Lines        5162     5177      +15     
==========================================
+ Hits         4383     4403      +20     
+ Misses        779      774       -5
Files Coverage Δ
daft/dataframe/dataframe.py 87.09% <34.78%> (-2.49%) ⬇️

... and 4 files with indirect coverage changes

View more details on Codecov