Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Improve error messages when calling aggregation methods on dataframe without input columns #1587

Merged
merged 5 commits into from
Nov 13, 2023

modify other agg methods

c038678
Select commit
Loading
Failed to load commit list.
Merged

[CHORE] Improve error messages when calling aggregation methods on dataframe without input columns #1587

modify other agg methods
c038678
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Nov 13, 2023 in 0s

34.78% of diff hit (target 84.90%)

View this Pull Request on Codecov

34.78% of diff hit (target 84.90%)

Annotations

Check warning on line 857 in daft/dataframe/dataframe.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/dataframe/dataframe.py#L857 

Added line #L857 was not covered by tests

Check warning on line 860 in daft/dataframe/dataframe.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/dataframe/dataframe.py#L860 

Added line #L860 was not covered by tests

Check warning on line 873 in daft/dataframe/dataframe.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/dataframe/dataframe.py#L873 

Added line #L873 was not covered by tests

Check warning on line 876 in daft/dataframe/dataframe.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/dataframe/dataframe.py#L876 

Added line #L876 was not covered by tests

Check warning on line 889 in daft/dataframe/dataframe.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/dataframe/dataframe.py#L889 

Added line #L889 was not covered by tests

Check warning on line 892 in daft/dataframe/dataframe.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/dataframe/dataframe.py#L892 

Added line #L892 was not covered by tests

Check warning on line 905 in daft/dataframe/dataframe.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/dataframe/dataframe.py#L905 

Added line #L905 was not covered by tests

Check warning on line 908 in daft/dataframe/dataframe.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/dataframe/dataframe.py#L908 

Added line #L908 was not covered by tests

Check warning on line 921 in daft/dataframe/dataframe.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/dataframe/dataframe.py#L921 

Added line #L921 was not covered by tests

Check warning on line 924 in daft/dataframe/dataframe.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/dataframe/dataframe.py#L924 

Added line #L924 was not covered by tests

Check warning on line 937 in daft/dataframe/dataframe.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/dataframe/dataframe.py#L937 

Added line #L937 was not covered by tests

Check warning on line 940 in daft/dataframe/dataframe.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/dataframe/dataframe.py#L940 

Added line #L940 was not covered by tests

Check warning on line 953 in daft/dataframe/dataframe.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/dataframe/dataframe.py#L952-L953 

Added lines #L952 - L953 were not covered by tests

Check warning on line 956 in daft/dataframe/dataframe.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

daft/dataframe/dataframe.py#L956 

Added line #L956 was not covered by tests
View more details on Codecov