Skip to content
This repository has been archived by the owner on Dec 3, 2024. It is now read-only.

[WEEKLY RELEASE] HotShot - rc-0.5.67 #526

[WEEKLY RELEASE] HotShot - rc-0.5.67

[WEEKLY RELEASE] HotShot - rc-0.5.67 #526

GitHub Actions / clippy failed Sep 20, 2024 in 0s

clippy

9 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 9
Warning 0
Note 0
Help 0

Versions

  • rustc 1.81.0 (eeb90cda1 2024-09-04)
  • cargo 1.81.0 (2dbb1af80 2024-08-20)
  • clippy 0.1.81 (eeb90cd 2024-09-04)

Annotations

Check failure on line 14 in src/builder_state.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `Committable`

error: unused import: `Committable`
  --> src/builder_state.rs:14:31
   |
14 | use committable::{Commitment, Committable};
   |                               ^^^^^^^^^^^
   |
   = note: `-D unused-imports` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(unused_imports)]`

Check failure on line 1151 in src/service.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

no method named `as_ref` found for opaque type `impl futures::Future<Output = committable::Commitment<hotshot_types::data::Leaf<Types>>>` in the current scope

error[E0599]: no method named `as_ref` found for opaque type `impl futures::Future<Output = committable::Commitment<hotshot_types::data::Leaf<Types>>>` in the current scope
    --> src/service.rs:1151:82
     |
1151 |     if sender == leader && sender.validate(&qc_proposal.signature, leaf.commit().as_ref()) {
     |                                                                                  ^^^^^^
     |
help: there is a method `pipe_as_ref` with a similar name, but with different arguments
    --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tap-1.0.1/src/pipe.rs:183:2
     |
183  | /     fn pipe_as_ref<'a, U, R>(&'a self, func: impl FnOnce(&'a U) -> R) -> R
184  | |     where
185  | |         Self: AsRef<U>,
186  | |         U: 'a + ?Sized,
187  | |         R: 'a + Sized,
     | |______________________^

Check failure on line 1151 in src/service.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this method takes 1 argument but 0 arguments were supplied

error[E0061]: this method takes 1 argument but 0 arguments were supplied
    --> src/service.rs:1151:73
     |
1151 |     if sender == leader && sender.validate(&qc_proposal.signature, leaf.commit().as_ref()) {
     |                                                                         ^^^^^^-- argument #1 of type `&hotshot_types::message::UpgradeLock<Types, _>` is missing
     |
note: method defined here
    --> /home/runner/.cargo/git/checkouts/hotshot-0ac703037ea89b98/b68065a/crates/types/src/data.rs:451:18
     |
451  |     pub async fn commit<V: Versions>(
     |                  ^^^^^^
help: provide the argument
     |
1151 |     if sender == leader && sender.validate(&qc_proposal.signature, leaf.commit(/* upgrade_lock */).as_ref()) {
     |                                                                               ~~~~~~~~~~~~~~~~~~~~

Check failure on line 857 in src/service.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

no function or associated item named `create_election` found for struct `hotshot::traits::election::static_committee::GeneralStaticCommittee` in the current scope

error[E0599]: no function or associated item named `create_election` found for struct `hotshot::traits::election::static_committee::GeneralStaticCommittee` in the current scope
   --> src/service.rs:857:81
    |
857 |             GeneralStaticCommittee::<Types, <Types as NodeType>::SignatureKey>::create_election(
    |                                                                                 ^^^^^^^^^^^^^^^ function or associated item not found in `GeneralStaticCommittee<Types>`

Check failure on line 857 in src/service.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

struct takes 1 generic argument but 2 generic arguments were supplied

error[E0107]: struct takes 1 generic argument but 2 generic arguments were supplied
   --> src/service.rs:857:13
    |
857 |             GeneralStaticCommittee::<Types, <Types as NodeType>::SignatureKey>::create_election(
    |             ^^^^^^^^^^^^^^^^^^^^^^          --------------------------------- help: remove this generic argument
    |             |
    |             expected 1 generic argument
    |
note: struct defined here, with 1 generic parameter: `T`
   --> /home/runner/.cargo/git/checkouts/hotshot-0ac703037ea89b98/b68065a/crates/hotshot/src/traits/election/static_committee.rs:25:12
    |
25  | pub struct GeneralStaticCommittee<T: NodeType> {
    |            ^^^^^^^^^^^^^^^^^^^^^^ -

Check failure on line 856 in src/service.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

struct takes 1 generic argument but 2 generic arguments were supplied

error[E0107]: struct takes 1 generic argument but 2 generic arguments were supplied
   --> src/service.rs:856:25
    |
856 |         let membership: GeneralStaticCommittee<Types, <Types as NodeType>::SignatureKey> =
    |                         ^^^^^^^^^^^^^^^^^^^^^^        --------------------------------- help: remove this generic argument
    |                         |
    |                         expected 1 generic argument
    |
note: struct defined here, with 1 generic parameter: `T`
   --> /home/runner/.cargo/git/checkouts/hotshot-0ac703037ea89b98/b68065a/crates/hotshot/src/traits/election/static_committee.rs:25:12
    |
25  | pub struct GeneralStaticCommittee<T: NodeType> {
    |            ^^^^^^^^^^^^^^^^^^^^^^ -

Check failure on line 827 in src/service.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

struct takes 1 generic argument but 2 generic arguments were supplied

error[E0107]: struct takes 1 generic argument but 2 generic arguments were supplied
   --> src/service.rs:827:5
    |
827 |     GeneralStaticCommittee<Types, <Types as NodeType>::SignatureKey>,
    |     ^^^^^^^^^^^^^^^^^^^^^^        --------------------------------- help: remove this generic argument
    |     |
    |     expected 1 generic argument
    |
note: struct defined here, with 1 generic parameter: `T`
   --> /home/runner/.cargo/git/checkouts/hotshot-0ac703037ea89b98/b68065a/crates/hotshot/src/traits/election/static_committee.rs:25:12
    |
25  | pub struct GeneralStaticCommittee<T: NodeType> {
    |            ^^^^^^^^^^^^^^^^^^^^^^ -

Check failure on line 444 in src/builder_state.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

mismatched types

error[E0308]: mismatched types
   --> src/builder_state.rs:444:54
    |
444 |         self.built_from_proposed_block.leaf_commit = leaf.commit();
    |         ------------------------------------------   ^^^^^^^^^^^^^ expected `Commitment<Leaf<TYPES>>`, found future
    |         |
    |         expected due to the type of this binding
    |
note: calling an async function returns a future
   --> src/builder_state.rs:444:54
    |
444 |         self.built_from_proposed_block.leaf_commit = leaf.commit();
    |                                                      ^^^^^^^^^^^^^
help: consider `await`ing on the `Future`
    |
444 |         self.built_from_proposed_block.leaf_commit = leaf.commit().await;
    |                                                                   ++++++

Check failure on line 444 in src/builder_state.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this method takes 1 argument but 0 arguments were supplied

error[E0061]: this method takes 1 argument but 0 arguments were supplied
   --> src/builder_state.rs:444:59
    |
444 |         self.built_from_proposed_block.leaf_commit = leaf.commit();
    |                                                           ^^^^^^-- argument #1 of type `&hotshot_types::message::UpgradeLock<TYPES, _>` is missing
    |
note: method defined here
   --> /home/runner/.cargo/git/checkouts/hotshot-0ac703037ea89b98/b68065a/crates/types/src/data.rs:451:18
    |
451 |     pub async fn commit<V: Versions>(
    |                  ^^^^^^
help: provide the argument
    |
444 |         self.built_from_proposed_block.leaf_commit = leaf.commit(/* upgrade_lock */);
    |                                                                 ~~~~~~~~~~~~~~~~~~~~