error: unused import: `Committable` --> src/builder_state.rs:14:31 | 14 | use committable::{Commitment, Committable}; | ^^^^^^^^^^^ | = note: `-D unused-imports` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unused_imports)]`

error[E0599]: no method named `as_ref` found for opaque type `impl futures::Future<Output = committable::Commitment<hotshot_types::data::Leaf<Types>>>` in the current scope --> src/service.rs:1151:82 | 1151 | if sender == leader && sender.validate(&qc_proposal.signature, leaf.commit().as_ref()) { | ^^^^^^ | help: there is a method `pipe_as_ref` with a similar name, but with different arguments --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tap-1.0.1/src/pipe.rs:183:2 | 183 | / fn pipe_as_ref<'a, U, R>(&'a self, func: impl FnOnce(&'a U) -> R) -> R 184 | | where 185 | | Self: AsRef<U>, 186 | | U: 'a + ?Sized, 187 | | R: 'a + Sized, | |______________________^

error[E0061]: this method takes 1 argument but 0 arguments were supplied --> src/service.rs:1151:73 | 1151 | if sender == leader && sender.validate(&qc_proposal.signature, leaf.commit().as_ref()) { | ^^^^^^-- argument #1 of type `&hotshot_types::message::UpgradeLock<Types, _>` is missing | note: method defined here --> /home/runner/.cargo/git/checkouts/hotshot-0ac703037ea89b98/b68065a/crates/types/src/data.rs:451:18 | 451 | pub async fn commit<V: Versions>( | ^^^^^^ help: provide the argument | 1151 | if sender == leader && sender.validate(&qc_proposal.signature, leaf.commit(/* upgrade_lock */).as_ref()) { | ~~~~~~~~~~~~~~~~~~~~

error[E0599]: no function or associated item named `create_election` found for struct `hotshot::traits::election::static_committee::GeneralStaticCommittee` in the current scope --> src/service.rs:857:81 | 857 | GeneralStaticCommittee::<Types, <Types as NodeType>::SignatureKey>::create_election( | ^^^^^^^^^^^^^^^ function or associated item not found in `GeneralStaticCommittee<Types>`

error[E0107]: struct takes 1 generic argument but 2 generic arguments were supplied --> src/service.rs:857:13 | 857 | GeneralStaticCommittee::<Types, <Types as NodeType>::SignatureKey>::create_election( | ^^^^^^^^^^^^^^^^^^^^^^ --------------------------------- help: remove this generic argument | | | expected 1 generic argument | note: struct defined here, with 1 generic parameter: `T` --> /home/runner/.cargo/git/checkouts/hotshot-0ac703037ea89b98/b68065a/crates/hotshot/src/traits/election/static_committee.rs:25:12 | 25 | pub struct GeneralStaticCommittee<T: NodeType> { | ^^^^^^^^^^^^^^^^^^^^^^ -

error[E0107]: struct takes 1 generic argument but 2 generic arguments were supplied --> src/service.rs:856:25 | 856 | let membership: GeneralStaticCommittee<Types, <Types as NodeType>::SignatureKey> = | ^^^^^^^^^^^^^^^^^^^^^^ --------------------------------- help: remove this generic argument | | | expected 1 generic argument | note: struct defined here, with 1 generic parameter: `T` --> /home/runner/.cargo/git/checkouts/hotshot-0ac703037ea89b98/b68065a/crates/hotshot/src/traits/election/static_committee.rs:25:12 | 25 | pub struct GeneralStaticCommittee<T: NodeType> { | ^^^^^^^^^^^^^^^^^^^^^^ -

error[E0107]: struct takes 1 generic argument but 2 generic arguments were supplied --> src/service.rs:827:5 | 827 | GeneralStaticCommittee<Types, <Types as NodeType>::SignatureKey>, | ^^^^^^^^^^^^^^^^^^^^^^ --------------------------------- help: remove this generic argument | | | expected 1 generic argument | note: struct defined here, with 1 generic parameter: `T` --> /home/runner/.cargo/git/checkouts/hotshot-0ac703037ea89b98/b68065a/crates/hotshot/src/traits/election/static_committee.rs:25:12 | 25 | pub struct GeneralStaticCommittee<T: NodeType> { | ^^^^^^^^^^^^^^^^^^^^^^ -

error[E0308]: mismatched types --> src/builder_state.rs:444:54 | 444 | self.built_from_proposed_block.leaf_commit = leaf.commit(); | ------------------------------------------ ^^^^^^^^^^^^^ expected `Commitment<Leaf<TYPES>>`, found future | | | expected due to the type of this binding | note: calling an async function returns a future --> src/builder_state.rs:444:54 | 444 | self.built_from_proposed_block.leaf_commit = leaf.commit(); | ^^^^^^^^^^^^^ help: consider `await`ing on the `Future` | 444 | self.built_from_proposed_block.leaf_commit = leaf.commit().await; | ++++++

error[E0061]: this method takes 1 argument but 0 arguments were supplied --> src/builder_state.rs:444:59 | 444 | self.built_from_proposed_block.leaf_commit = leaf.commit(); | ^^^^^^-- argument #1 of type `&hotshot_types::message::UpgradeLock<TYPES, _>` is missing | note: method defined here --> /home/runner/.cargo/git/checkouts/hotshot-0ac703037ea89b98/b68065a/crates/types/src/data.rs:451:18 | 451 | pub async fn commit<V: Versions>( | ^^^^^^ help: provide the argument | 444 | self.built_from_proposed_block.leaf_commit = leaf.commit(/* upgrade_lock */); | ~~~~~~~~~~~~~~~~~~~~

Clippy had exited with the 101 exit code

error: unused import: `Committable` --> src/builder_state.rs:14:31 | 14 | use committable::{Commitment, Committable}; | ^^^^^^^^^^^ | = note: `-D unused-imports` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unused_imports)]`

error[E0308]: mismatched types --> src/testing/basic_test.rs:222:38 | 222 | leaf_commit: leaf.commit(), | ^^^^^^^^^^^^^ expected `Commitment<Leaf<TestTypes>>`, found future | note: calling an async function returns a future --> src/testing/basic_test.rs:222:38 | 222 | leaf_commit: leaf.commit(), | ^^^^^^^^^^^^^ help: consider `await`ing on the `Future` | 222 | leaf_commit: leaf.commit().await, | ++++++

error[E0061]: this method takes 1 argument but 0 arguments were supplied --> src/testing/basic_test.rs:222:43 | 222 | leaf_commit: leaf.commit(), | ^^^^^^-- argument #1 of type `&hotshot_types::message::UpgradeLock<testing::basic_test::tests::test_builder::{closure#0}::TestTypes, _>` is missing | note: method defined here --> /home/runner/.cargo/git/checkouts/hotshot-0ac703037ea89b98/b68065a/crates/types/src/data.rs:451:18 | 451 | pub async fn commit<V: Versions>( | ^^^^^^ help: provide the argument | 222 | leaf_commit: leaf.commit(/* upgrade_lock */), | ~~~~~~~~~~~~~~~~~~~~

error[E0063]: missing fields `metadata` and `random` in initializer of `hotshot_example_types::block_types::TestBlockHeader` --> src/testing/basic_test.rs:196:32 | 196 | let block_header = TestBlockHeader { | ^^^^^^^^^^^^^^^ missing `metadata` and `random`

error: unused import: `Committable` --> src/builder_state.rs:14:31 | 14 | use committable::{Commitment, Committable}; | ^^^^^^^^^^^ | = note: `-D unused-imports` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unused_imports)]`

error[E0107]: struct takes 1 generic argument but 2 generic arguments were supplied --> src/testing/basic_test.rs:83:31 | 83 | type Membership = GeneralStaticCommittee<TestTypes, Self::SignatureKey>; | ^^^^^^^^^^^^^^^^^^^^^^ ------------------ help: remove this generic argument | | | expected 1 generic argument | note: struct defined here, with 1 generic parameter: `T` --> /home/runner/.cargo/git/checkouts/hotshot-0ac703037ea89b98/b68065a/crates/hotshot/src/traits/election/static_committee.rs:25:12 | 25 | pub struct GeneralStaticCommittee<T: NodeType> { | ^^^^^^^^^^^^^^^^^^^^^^ -

error[E0599]: no method named `as_ref` found for opaque type `impl futures::Future<Output = committable::Commitment<hotshot_types::data::Leaf<Types>>>` in the current scope --> src/service.rs:1151:82 | 1151 | if sender == leader && sender.validate(&qc_proposal.signature, leaf.commit().as_ref()) { | ^^^^^^ | help: there is a method `pipe_as_ref` with a similar name, but with different arguments --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tap-1.0.1/src/pipe.rs:183:2 | 183 | / fn pipe_as_ref<'a, U, R>(&'a self, func: impl FnOnce(&'a U) -> R) -> R 184 | | where 185 | | Self: AsRef<U>, 186 | | U: 'a + ?Sized, 187 | | R: 'a + Sized, | |______________________^

error[E0599]: no method named `as_ref` found for opaque type `impl futures::Future<Output = committable::Commitment<hotshot_types::data::Leaf<Types>>>` in the current scope --> src/service.rs:1151:82 | 1151 | if sender == leader && sender.validate(&qc_proposal.signature, leaf.commit().as_ref()) { | ^^^^^^ | help: there is a method `pipe_as_ref` with a similar name, but with different arguments --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tap-1.0.1/src/pipe.rs:183:2 | 183 | / fn pipe_as_ref<'a, U, R>(&'a self, func: impl FnOnce(&'a U) -> R) -> R 184 | | where 185 | | Self: AsRef<U>, 186 | | U: 'a + ?Sized, 187 | | R: 'a + Sized, | |______________________^

error[E0061]: this method takes 1 argument but 0 arguments were supplied --> src/service.rs:1151:73 | 1151 | if sender == leader && sender.validate(&qc_proposal.signature, leaf.commit().as_ref()) { | ^^^^^^-- argument #1 of type `&hotshot_types::message::UpgradeLock<Types, _>` is missing | note: method defined here --> /home/runner/.cargo/git/checkouts/hotshot-0ac703037ea89b98/b68065a/crates/types/src/data.rs:451:18 | 451 | pub async fn commit<V: Versions>( | ^^^^^^ help: provide the argument | 1151 | if sender == leader && sender.validate(&qc_proposal.signature, leaf.commit(/* upgrade_lock */).as_ref()) { | ~~~~~~~~~~~~~~~~~~~~

error[E0061]: this method takes 1 argument but 0 arguments were supplied --> src/service.rs:1151:73 | 1151 | if sender == leader && sender.validate(&qc_proposal.signature, leaf.commit().as_ref()) { | ^^^^^^-- argument #1 of type `&hotshot_types::message::UpgradeLock<Types, _>` is missing | note: method defined here --> /home/runner/.cargo/git/checkouts/hotshot-0ac703037ea89b98/b68065a/crates/types/src/data.rs:451:18 | 451 | pub async fn commit<V: Versions>( | ^^^^^^ help: provide the argument | 1151 | if sender == leader && sender.validate(&qc_proposal.signature, leaf.commit(/* upgrade_lock */).as_ref()) { | ~~~~~~~~~~~~~~~~~~~~

error[E0599]: no function or associated item named `create_election` found for struct `hotshot::traits::election::static_committee::GeneralStaticCommittee` in the current scope --> src/service.rs:857:81 | 857 | GeneralStaticCommittee::<Types, <Types as NodeType>::SignatureKey>::create_election( | ^^^^^^^^^^^^^^^ function or associated item not found in `GeneralStaticCommittee<Types>`

error[E0599]: no function or associated item named `create_election` found for struct `hotshot::traits::election::static_committee::GeneralStaticCommittee` in the current scope --> src/service.rs:857:81 | 857 | GeneralStaticCommittee::<Types, <Types as NodeType>::SignatureKey>::create_election( | ^^^^^^^^^^^^^^^ function or associated item not found in `GeneralStaticCommittee<Types>`

error[E0107]: struct takes 1 generic argument but 2 generic arguments were supplied --> src/service.rs:857:13 | 857 | GeneralStaticCommittee::<Types, <Types as NodeType>::SignatureKey>::create_election( | ^^^^^^^^^^^^^^^^^^^^^^ --------------------------------- help: remove this generic argument | | | expected 1 generic argument | note: struct defined here, with 1 generic parameter: `T` --> /home/runner/.cargo/git/checkouts/hotshot-0ac703037ea89b98/b68065a/crates/hotshot/src/traits/election/static_committee.rs:25:12 | 25 | pub struct GeneralStaticCommittee<T: NodeType> { | ^^^^^^^^^^^^^^^^^^^^^^ -

error[E0107]: struct takes 1 generic argument but 2 generic arguments were supplied --> src/service.rs:857:13 | 857 | GeneralStaticCommittee::<Types, <Types as NodeType>::SignatureKey>::create_election( | ^^^^^^^^^^^^^^^^^^^^^^ --------------------------------- help: remove this generic argument | | | expected 1 generic argument | note: struct defined here, with 1 generic parameter: `T` --> /home/runner/.cargo/git/checkouts/hotshot-0ac703037ea89b98/b68065a/crates/hotshot/src/traits/election/static_committee.rs:25:12 | 25 | pub struct GeneralStaticCommittee<T: NodeType> { | ^^^^^^^^^^^^^^^^^^^^^^ -

error[E0107]: struct takes 1 generic argument but 2 generic arguments were supplied --> src/service.rs:856:25 | 856 | let membership: GeneralStaticCommittee<Types, <Types as NodeType>::SignatureKey> = | ^^^^^^^^^^^^^^^^^^^^^^ --------------------------------- help: remove this generic argument | | | expected 1 generic argument | note: struct defined here, with 1 generic parameter: `T` --> /home/runner/.cargo/git/checkouts/hotshot-0ac703037ea89b98/b68065a/crates/hotshot/src/traits/election/static_committee.rs:25:12 | 25 | pub struct GeneralStaticCommittee<T: NodeType> { | ^^^^^^^^^^^^^^^^^^^^^^ -

error[E0107]: struct takes 1 generic argument but 2 generic arguments were supplied --> src/service.rs:856:25 | 856 | let membership: GeneralStaticCommittee<Types, <Types as NodeType>::SignatureKey> = | ^^^^^^^^^^^^^^^^^^^^^^ --------------------------------- help: remove this generic argument | | | expected 1 generic argument | note: struct defined here, with 1 generic parameter: `T` --> /home/runner/.cargo/git/checkouts/hotshot-0ac703037ea89b98/b68065a/crates/hotshot/src/traits/election/static_committee.rs:25:12 | 25 | pub struct GeneralStaticCommittee<T: NodeType> { | ^^^^^^^^^^^^^^^^^^^^^^ -

error[E0107]: struct takes 1 generic argument but 2 generic arguments were supplied --> src/service.rs:827:5 | 827 | GeneralStaticCommittee<Types, <Types as NodeType>::SignatureKey>, | ^^^^^^^^^^^^^^^^^^^^^^ --------------------------------- help: remove this generic argument | | | expected 1 generic argument | note: struct defined here, with 1 generic parameter: `T` --> /home/runner/.cargo/git/checkouts/hotshot-0ac703037ea89b98/b68065a/crates/hotshot/src/traits/election/static_committee.rs:25:12 | 25 | pub struct GeneralStaticCommittee<T: NodeType> { | ^^^^^^^^^^^^^^^^^^^^^^ -

error[E0107]: struct takes 1 generic argument but 2 generic arguments were supplied --> src/service.rs:827:5 | 827 | GeneralStaticCommittee<Types, <Types as NodeType>::SignatureKey>, | ^^^^^^^^^^^^^^^^^^^^^^ --------------------------------- help: remove this generic argument | | | expected 1 generic argument | note: struct defined here, with 1 generic parameter: `T` --> /home/runner/.cargo/git/checkouts/hotshot-0ac703037ea89b98/b68065a/crates/hotshot/src/traits/election/static_committee.rs:25:12 | 25 | pub struct GeneralStaticCommittee<T: NodeType> { | ^^^^^^^^^^^^^^^^^^^^^^ -

error[E0308]: mismatched types --> src/builder_state.rs:444:54 | 444 | self.built_from_proposed_block.leaf_commit = leaf.commit(); | ------------------------------------------ ^^^^^^^^^^^^^ expected `Commitment<Leaf<TYPES>>`, found future | | | expected due to the type of this binding | note: calling an async function returns a future --> src/builder_state.rs:444:54 | 444 | self.built_from_proposed_block.leaf_commit = leaf.commit(); | ^^^^^^^^^^^^^ help: consider `await`ing on the `Future` | 444 | self.built_from_proposed_block.leaf_commit = leaf.commit().await; | ++++++

error[E0308]: mismatched types --> src/builder_state.rs:444:54 | 444 | self.built_from_proposed_block.leaf_commit = leaf.commit(); | ------------------------------------------ ^^^^^^^^^^^^^ expected `Commitment<Leaf<TYPES>>`, found future | | | expected due to the type of this binding | note: calling an async function returns a future --> src/builder_state.rs:444:54 | 444 | self.built_from_proposed_block.leaf_commit = leaf.commit(); | ^^^^^^^^^^^^^ help: consider `await`ing on the `Future` | 444 | self.built_from_proposed_block.leaf_commit = leaf.commit().await; | ++++++

error[E0061]: this method takes 1 argument but 0 arguments were supplied --> src/builder_state.rs:444:59 | 444 | self.built_from_proposed_block.leaf_commit = leaf.commit(); | ^^^^^^-- argument #1 of type `&hotshot_types::message::UpgradeLock<TYPES, _>` is missing | note: method defined here --> /home/runner/.cargo/git/checkouts/hotshot-0ac703037ea89b98/b68065a/crates/types/src/data.rs:451:18 | 451 | pub async fn commit<V: Versions>( | ^^^^^^ help: provide the argument | 444 | self.built_from_proposed_block.leaf_commit = leaf.commit(/* upgrade_lock */); | ~~~~~~~~~~~~~~~~~~~~

error[E0061]: this method takes 1 argument but 0 arguments were supplied --> src/builder_state.rs:444:59 | 444 | self.built_from_proposed_block.leaf_commit = leaf.commit(); | ^^^^^^-- argument #1 of type `&hotshot_types::message::UpgradeLock<TYPES, _>` is missing | note: method defined here --> /home/runner/.cargo/git/checkouts/hotshot-0ac703037ea89b98/b68065a/crates/types/src/data.rs:451:18 | 451 | pub async fn commit<V: Versions>( | ^^^^^^ help: provide the argument | 444 | self.built_from_proposed_block.leaf_commit = leaf.commit(/* upgrade_lock */); | ~~~~~~~~~~~~~~~~~~~~

error[E0423]: expected value, found struct `TestMetadata` --> src/testing/basic_test.rs:142:27 | 142 | metadata: TestMetadata, | ^^^^^^^^^^^^ help: use struct literal syntax instead: `TestMetadata { num_transactions: val }` | ::: /home/runner/.cargo/git/checkouts/hotshot-0ac703037ea89b98/b68065a/crates/example-types/src/block_types.rs:161:1 | 161 | pub struct TestMetadata { | ----------------------- `TestMetadata` defined here

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/