This repository has been archived by the owner on Dec 3, 2024. It is now read-only.

Windows build

Testing Builder core logic #23

Triggered via pull request February 15, 2024 04:35

move47

synchronize #30

testing_builder_core

Status Failure

Total duration 15m 0s

Artifacts –

build_windows.yml

on: pull_request

windows

14m 48s

Annotations

85 errors and 1 warning

casting to the same type is unnecessary (`usize` -> `usize`): src/testing/basic_test.rs#L439

error: casting to the same type is unnecessary (`usize` -> `usize`) --> src/testing/basic_test.rs:439:37 | 439 | assert_eq!(rres_msgs.len(), (num_test_messages - 1) as usize); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `{ (num_test_messages - 1) }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

casting integer literal to `u64` is unnecessary: src/testing/basic_test.rs#L386

error: casting integer literal to `u64` is unnecessary --> src/testing/basic_test.rs:386:58 | 386 | BLSPubKey::generated_from_seed_indexed(seed, 2011 as u64); | ^^^^^^^^^^^ help: try: `2011_u64` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

casting integer literal to `u8` is unnecessary: src/testing/basic_test.rs#L384

error: casting integer literal to `u8` is unnecessary --> src/testing/basic_test.rs:384:21 | 384 | let seed = [201 as u8; 32]; | ^^^^^^^^^ help: try: `201_u8` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `-D clippy::unnecessary-cast` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::unnecessary_cast)]`

using `clone` on type `ViewNumber` which implements the `Copy` trait: src/testing/basic_test.rs#L219

error: using `clone` on type `ViewNumber` which implements the `Copy` trait --> src/testing/basic_test.rs:219:38 | 219 | view_number: sqc_msgs[(i - 1) as usize].proposal.data.view_number.clone(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `sqc_msgs[(i - 1) as usize].proposal.data.view_number` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

returning the result of a `let` binding from a block: src/testing/basic_test.rs#L262

error: returning the result of a `let` binding from a block --> src/testing/basic_test.rs:262:21 | 253 | / let justify_qc = 254 | | SimpleCertificate::<TestTypes, QuorumData<TestTypes>, SuccessThreshold> { 255 | | data: q_data.clone(), 256 | | vote_commitment: q_data.commit(), ... | 260 | | _pd: PhantomData, 261 | | }; | |__________________________- unnecessary `let` binding 262 | justify_qc | ^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `-D clippy::let-and-return` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::let_and_return)]` help: return the expression directly | 253 ~ 254 ~ SimpleCertificate::<TestTypes, QuorumData<TestTypes>, SuccessThreshold> { 255 + data: q_data.clone(), 256 + vote_commitment: q_data.commit(), 257 + view_number: view_number, 258 + signatures: previous_justify_qc.signatures.clone(), 259 + is_genesis: true, // todo setting true because we don't have signatures of QCType 260 + _pd: PhantomData, 261 + } |

using `clone` on type `HasherNode<CoreWrapper<CtVariableCoreWrapper<Sha256VarCore, UInt<UInt<UInt<UInt<UInt<UInt<UTerm, B1>, B0>, B0>, B0>, B0>, B0>, OidSha256>>>` which implements the `Copy` trait: src/service.rs#L111

error: using `clone` on type `HasherNode<CoreWrapper<CtVariableCoreWrapper<Sha256VarCore, UInt<UInt<UInt<UInt<UInt<UInt<UTerm, B1>, B0>, B0>, B0>, B0>, B0>, OidSha256>>>` which implements the `Copy` trait --> src/service.rs:111:39 | 111 | requested_vid_commitment: for_parent.clone(), | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*for_parent` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

very complex type used. Consider factoring parts into `type` definitions: src/service.rs#L61

error: very complex type used. Consider factoring parts into `type` definitions --> src/service.rs:61:30 | 61 | pub block_hash_to_block: HashMap< | ______________________________^ 62 | | BuilderCommitment, 63 | | ( 64 | | Types::BlockPayload, ... | 69 | | ), 70 | | >, | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `-D clippy::type-complexity` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::type_complexity)]`

this function has too many arguments (10/7): src/builder_state.rs#L754

error: this function has too many arguments (10/7) --> src/builder_state.rs:754:5 | 754 | / pub fn new( 755 | | builder_keys: ( 756 | | TYPES::SignatureKey, 757 | | <<TYPES as BuilderType>::SignatureKey as SignatureKey>::PrivateKey, ... | 767 | | quorum_membership: Arc<TYPES::Membership>, 768 | | ) -> Self { | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `-D clippy::too-many-arguments` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::too_many_arguments)]`

very complex type used. Consider factoring parts into `type` definitions: src/service.rs#L61

this function has too many arguments (10/7): src/builder_state.rs#L754

useless conversion to the same type: `<<TYPES as hotshot_types::traits::node_implementation::NodeType>::BlockPayload as hotshot_types::traits::BlockPayload>::Encode<'_>`: src/builder_state.rs#L538

error: useless conversion to the same type: `<<TYPES as hotshot_types::traits::node_implementation::NodeType>::BlockPayload as hotshot_types::traits::BlockPayload>::Encode<'_>` --> src/builder_state.rs:538:41 | 538 | let encoded_txns: Vec<u8> = payload.encode().unwrap().into_iter().collect(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `payload.encode().unwrap()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-D clippy::useless-conversion` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`

this expression creates a reference which is immediately dereferenced by the compiler: src/builder_state.rs#L460

error: this expression creates a reference which is immediately dereferenced by the compiler --> src/builder_state.rs:460:67 | 460 | ... self.tx_hash_to_available_txns.remove(&tx_hash); | ^^^^^^^^ help: change this to: `tx_hash` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

this expression creates a reference which is immediately dereferenced by the compiler: src/builder_state.rs#L455

error: this expression creates a reference which is immediately dereferenced by the compiler --> src/builder_state.rs:455:64 | 455 | ... self.tx_hash_to_available_txns.get(&tx_hash) | ^^^^^^^^ help: change this to: `tx_hash` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

this expression creates a reference which is immediately dereferenced by the compiler: src/builder_state.rs#L449

error: this expression creates a reference which is immediately dereferenced by the compiler --> src/builder_state.rs:449:90 | 449 | let transactions_commitments = block_payload.transaction_commitments(&metadata); | ^^^^^^^^^ help: change this to: `metadata` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`

error: using `clone` on type `HasherNode<CoreWrapper<CtVariableCoreWrapper<Sha256VarCore, UInt<UInt<UInt<UInt<UInt<UInt<UTerm, B1>, B0>, B0>, B0>, B0>, B0>, OidSha256>>>` which implements the `Copy` trait --> src/builder_state.rs:380:24 | 380 | .entry(payload_vid_commitment.clone()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `payload_vid_commitment` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

usage of `contains_key` followed by `insert` on a `HashMap`: src/builder_state.rs#L373

error: usage of `contains_key` followed by `insert` on a `HashMap` --> src/builder_state.rs:373:9 | 373 | / if !self 374 | | .quorum_proposal_payload_commit_to_quorum_proposal 375 | | .contains_key(&payload_vid_commitment) 376 | | { ... | 397 | | } 398 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry help: try | 373 ~ if let std::collections::hash_map::Entry::Vacant(e) = self 374 + .quorum_proposal_payload_commit_to_quorum_proposal.entry(payload_vid_commitment) { 375 + // if we have matching da and quorum proposals, we can skip storing the one, and remove the other from storage, and call build_block with both, to save a little space. 376 + if let Entry::Occupied(da_proposal_data) = self 377 + .da_proposal_payload_commit_to_da_proposal 378 + .entry(payload_vid_commitment.clone()) 379 + { 380 + let da_proposal_data = da_proposal_data.remove(); 381 + 382 + // make sure we don't clone for the bootstrapping da and qc proposals 383 + if da_proposal_data.view_number.get_u64() != 0 { 384 + tracing::info!("Spawning a clone"); 385 + self.clone() 386 + .spawn_clone(da_proposal_data, qc_proposal_data, sender); 387 + // registed the clone to the global state 388 + //self.global_state.get_mut().vid_to_potential_builder_state.insert(payload_vid_commitment, self_clone); 389 + } else { 390 + tracing::info!("Not spawning a clone despite matching DA and QC proposals, as they corresponds to bootstrapping phase"); 391 + } 392 + } else { 393 + e.insert(qc_proposal_data.clone()); 394 + } 395 + } |

this expression creates a reference which is immediately dereferenced by the compiler: src/builder_state.rs#L460

this expression creates a reference which is immediately dereferenced by the compiler: src/builder_state.rs#L455

this expression creates a reference which is immediately dereferenced by the compiler: src/builder_state.rs#L449

error: using `clone` on type `HasherNode<CoreWrapper<CtVariableCoreWrapper<Sha256VarCore, UInt<UInt<UInt<UInt<UInt<UInt<UTerm, B1>, B0>, B0>, B0>, B0>, B0>, OidSha256>>>` which implements the `Copy` trait --> src/builder_state.rs:380:24 | 380 | .entry(payload_vid_commitment.clone()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `payload_vid_commitment` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

error: using `clone` on type `HasherNode<CoreWrapper<CtVariableCoreWrapper<Sha256VarCore, UInt<UInt<UInt<UInt<UInt<UInt<UTerm, B1>, B0>, B0>, B0>, B0>, B0>, OidSha256>>>` which implements the `Copy` trait --> src/builder_state.rs:318:24 | 318 | .entry(payload_vid_commitment.clone()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `payload_vid_commitment` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

usage of `contains_key` followed by `insert` on a `HashMap`: src/builder_state.rs#L373

usage of `contains_key` followed by `insert` on a `HashMap`: src/builder_state.rs#L305

error: usage of `contains_key` followed by `insert` on a `HashMap` --> src/builder_state.rs:305:9 | 305 | / if !self 306 | | .da_proposal_payload_commit_to_da_proposal 307 | | .contains_key(&payload_vid_commitment) 308 | | { ... | 335 | | } 336 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry = note: `-D clippy::map-entry` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::map_entry)]` help: try | 305 ~ if let std::collections::hash_map::Entry::Vacant(e) = self 306 + .da_proposal_payload_commit_to_da_proposal.entry(payload_vid_commitment) { 307 + let da_proposal_data = DAProposal { 308 + encoded_transactions: encoded_txns.clone(), 309 + metadata: metadata.clone(), 310 + view_number: view_number, 311 + }; 312 + 313 + // if we have matching da and quorum proposals, we can skip storing the one, and remove the other from storage, and call build_block with both, to save a little space. 314 + if let Entry::Occupied(qc_proposal_data) = self 315 + .quorum_proposal_payload_commit_to_quorum_proposal 316 + .entry(payload_vid_commitment.clone()) 317 + { 318 + let qc_proposal_data = qc_proposal_data.remove(); 319 + 320 + // make sure we don't clone for the bootstrapping da and qc proposals 321 + if qc_proposal_data.view_number.get_u64() != 0 { 322 + tracing::info!("Spawning a clone"); 323 + self.clone() 324 + .spawn_clone(da_proposal_data, qc_proposal_data, sender); 325 + // register the clone to the global state 326 + //self.global_state.get_mut().vid_to_potential_builder_state.insert(payload_vid_commitment, self_clone); 327 + } else { 328 + tracing::info!("Not spawning a clone despite matching DA and QC proposals, as they corresponds to bootstrapping phase"); 329 + } 330 + } else { 331 + e.insert(da_proposal_data); 332 + } 333 + } |

error: using `clone` on type `HasherNode<CoreWrapper<CtVariableCoreWrapper<Sha256VarCore, UInt<UInt<UInt<UInt<UInt<UInt<UTerm, B1>, B0>, B0>, B0>, B0>, B0>, OidSha256>>>` which implements the `Copy` trait --> src/builder_state.rs:318:24 | 318 | .entry(payload_vid_commitment.clone()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `payload_vid_commitment` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

usage of `contains_key` followed by `insert` on a `HashMap`: src/builder_state.rs#L305

using `clone` on type `Commitment<<TYPES as NodeType>::Transaction>` which implements the `Copy` trait: src/builder_state.rs#L257

error: using `clone` on type `Commitment<<TYPES as NodeType>::Transaction>` which implements the `Copy` trait --> src/builder_state.rs:257:55 | 257 | self.timestamp_to_tx.insert(tx_timestamp, tx_hash.clone()); | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `tx_hash` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

using `clone` on type `Commitment<<TYPES as NodeType>::Transaction>` which implements the `Copy` trait: src/builder_state.rs#L257

using `clone` on type `Commitment<<TYPES as NodeType>::Transaction>` which implements the `Copy` trait: src/builder_state.rs#L229

error: using `clone` on type `Commitment<<TYPES as NodeType>::Transaction>` which implements the `Copy` trait --> src/builder_state.rs:229:55 | 229 | self.timestamp_to_tx.insert(tx_timestamp, tx_hash.clone()); | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `tx_hash` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `-D clippy::clone-on-copy` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::clone_on_copy)]`

using `clone` on type `Commitment<<TYPES as NodeType>::Transaction>` which implements the `Copy` trait: src/builder_state.rs#L229

unneeded `return` statement: src/builder_state.rs#L219

error: unneeded `return` statement --> src/builder_state.rs:219:117 | 219 | tracing::info!("Transaction already exists in the builderinfo.txid_to_tx hashmap, So we can ignore it"); | _____________________________________________________________________________________________________________________^ 220 | | return; | |__________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `-D clippy::needless-return` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_return)]` help: remove `return` | 219 - tracing::info!("Transaction already exists in the builderinfo.txid_to_tx hashmap, So we can ignore it"); 220 - return; 219 + tracing::info!("Transaction already exists in the builderinfo.txid_to_tx hashmap, So we can ignore it"); |

unneeded `return` statement: src/builder_state.rs#L219

variable does not need to be mutable: src/testing/basic_test.rs#L389

error: variable does not need to be mutable --> src/testing/basic_test.rs:389:17 | 389 | let mut builder_state = BuilderState::<TestTypes>::new( | ----^^^^^^^^^^^^^ | | | help: remove this `mut` | = note: `-D unused-mut` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unused_mut)]`

unused variable: `block_header`: src/testing/basic_test.rs#L183

error: unused variable: `block_header` --> src/testing/basic_test.rs:183:17 | 183 | let block_header = TestBlockHeader { | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_block_header` | = note: `-D unused-variables` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unused_variables)]`

redundant field names in struct initialization: src/service.rs#L267

error: redundant field names in struct initialization --> src/service.rs:267:29 | 267 | ... block_size: block_size, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_size` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: src/service.rs#L266

error: redundant field names in struct initialization --> src/service.rs:266:29 | 266 | ... qc: qc, | ^^^^^^ help: replace it with: `qc` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: src/service.rs#L265

error: redundant field names in struct initialization --> src/service.rs:265:29 | 265 | ... leaf_chain: leaf_chain, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `leaf_chain` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: src/service.rs#L250

error: redundant field names in struct initialization --> src/service.rs:250:33 | 250 | ... sender: sender, | ^^^^^^^^^^^^^^ help: replace it with: `sender` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: src/service.rs#L249

error: redundant field names in struct initialization --> src/service.rs:249:33 | 249 | ... proposal: proposal, | ^^^^^^^^^^^^^^^^^^ help: replace it with: `proposal` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: src/service.rs#L228

error: redundant field names in struct initialization --> src/service.rs:228:33 | 228 | ... sender: sender, | ^^^^^^^^^^^^^^ help: replace it with: `sender` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: src/service.rs#L227

error: redundant field names in struct initialization --> src/service.rs:227:33 | 227 | ... proposal: proposal, | ^^^^^^^^^^^^^^^^^^ help: replace it with: `proposal` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: src/service.rs#L93

error: redundant field names in struct initialization --> src/service.rs:93:13 | 93 | response_receiver: response_receiver, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `response_receiver` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: src/service.rs#L92

error: redundant field names in struct initialization --> src/service.rs:92:13 | 92 | request_sender: request_sender, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `request_sender` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: src/builder_state.rs#L785

error: redundant field names in struct initialization --> src/builder_state.rs:785:13 | 785 | quorum_membership: quorum_membership, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `quorum_membership` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: src/builder_state.rs#L784

error: redundant field names in struct initialization --> src/builder_state.rs:784:13 | 784 | response_sender: response_sender, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `response_sender` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: src/builder_state.rs#L783

error: redundant field names in struct initialization --> src/builder_state.rs:783:13 | 783 | global_state: global_state, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `global_state` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: src/builder_state.rs#L780

error: redundant field names in struct initialization --> src/builder_state.rs:780:13 | 780 | req_receiver: req_receiver, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `req_receiver` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: src/builder_state.rs#L779

error: redundant field names in struct initialization --> src/builder_state.rs:779:13 | 779 | qc_receiver: qc_receiver, | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `qc_receiver` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: src/builder_state.rs#L778

error: redundant field names in struct initialization --> src/builder_state.rs:778:13 | 778 | da_proposal_receiver: da_proposal_receiver, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `da_proposal_receiver` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: src/builder_state.rs#L777

error: redundant field names in struct initialization --> src/builder_state.rs:777:13 | 777 | decide_receiver: decide_receiver, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `decide_receiver` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: src/builder_state.rs#L776

error: redundant field names in struct initialization --> src/builder_state.rs:776:13 | 776 | tx_receiver: tx_receiver, | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tx_receiver` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: src/builder_state.rs#L770

error: redundant field names in struct initialization --> src/builder_state.rs:770:13 | 770 | builder_keys: builder_keys, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `builder_keys` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: src/builder_state.rs#L585

error: redundant field names in struct initialization --> src/builder_state.rs:585:17 | 585 | metadata: metadata, | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: src/builder_state.rs#L583

error: redundant field names in struct initialization --> src/builder_state.rs:583:17 | 583 | offered_fee: offered_fee, | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `offered_fee` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: src/builder_state.rs#L582

error: redundant field names in struct initialization --> src/builder_state.rs:582:17 | 582 | block_size: block_size, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_size` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: src/builder_state.rs#L581

error: redundant field names in struct initialization --> src/builder_state.rs:581:17 | 581 | block_hash: block_hash, | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_hash` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: src/testing/basic_test.rs#L342

error: redundant field names in struct initialization --> src/testing/basic_test.rs:342:17 | 342 | requested_vid_commitment: requested_vid_commitment, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `requested_vid_commitment` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: src/testing/basic_test.rs#L269

error: redundant field names in struct initialization --> src/testing/basic_test.rs:269:17 | 269 | block_header: block_header, | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_header` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: src/testing/basic_test.rs#L257

error: redundant field names in struct initialization --> src/testing/basic_test.rs:257:29 | 257 | ... view_number: view_number, | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `view_number` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

redundant field names in struct initialization: src/service.rs#L267

redundant field names in struct initialization: src/service.rs#L266

redundant field names in struct initialization: src/service.rs#L265

redundant field names in struct initialization: src/service.rs#L250

redundant field names in struct initialization: src/service.rs#L249

redundant field names in struct initialization: src/service.rs#L228

redundant field names in struct initialization: src/service.rs#L227

redundant field names in struct initialization: src/service.rs#L93

redundant field names in struct initialization: src/service.rs#L92

redundant field names in struct initialization: src/builder_state.rs#L785

redundant field names in struct initialization: src/builder_state.rs#L784

redundant field names in struct initialization: src/builder_state.rs#L783

redundant field names in struct initialization: src/builder_state.rs#L780

redundant field names in struct initialization: src/builder_state.rs#L779

redundant field names in struct initialization: src/builder_state.rs#L778

redundant field names in struct initialization: src/builder_state.rs#L777

redundant field names in struct initialization: src/builder_state.rs#L776

redundant field names in struct initialization: src/builder_state.rs#L770

redundant field names in struct initialization: src/builder_state.rs#L585

redundant field names in struct initialization: src/builder_state.rs#L583

redundant field names in struct initialization: src/builder_state.rs#L582

redundant field names in struct initialization: src/builder_state.rs#L581

redundant field names in struct initialization: src/builder_state.rs#L312

error: redundant field names in struct initialization --> src/builder_state.rs:312:17 | 312 | view_number: view_number, | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `view_number` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names = note: `-D clippy::redundant-field-names` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::redundant_field_names)]`

redundant field names in struct initialization: src/builder_state.rs#L312

windows

Process completed with exit code 1.

windows

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: arduino/setup-protoc@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Testing Builder core logic #23

Summary