Skip to content
This repository has been archived by the owner on Dec 3, 2024. It is now read-only.

Testing Builder core logic #30

Merged
merged 62 commits into from
Feb 16, 2024
Merged

Testing Builder core logic #30

merged 62 commits into from
Feb 16, 2024

Conversation

move47
Copy link
Contributor

@move47 move47 commented Feb 13, 2024

  • Includes bootstrap logic
  • Includes an end-to-end test to simulate the builder logic.

To test: RUSTFLAGS='--cfg async_executor_impl="async-std" --cfg async_channel_impl="async-std"' ASYNC_STD_THREAD_COUNT=8 cargo test

@move47 move47 mentioned this pull request Feb 13, 2024
@move47 move47 requested a review from nyospe February 13, 2024 21:17
@move47 move47 linked an issue Feb 13, 2024 that may be closed by this pull request
6 tasks
@move47 move47 self-assigned this Feb 13, 2024
.gitignore Outdated
@@ -5,7 +5,7 @@ target/
target_dirs/
# Remove Cargo.lock from gitignore if creating an executable, leave it for libraries
# More information here https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html
Cargo.lock
#Cargo.lock
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't remove from .gitignore, just check it in...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Contributor

@nyospe nyospe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can use some work, but this is a significant step forward as it is, and should go in. We can do another PR after...

@move47 move47 merged commit c9f7d71 into main Feb 16, 2024
4 checks passed
@move47 move47 deleted the testing_builder_core branch February 16, 2024 20:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MACRO] Integration with Hotshot/APIs
2 participants