Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/free downloads issue #78

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Bugfix/free downloads issue #78

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
c95b75b
Fixes an issue prevents writing paths that end in '...' or similar
Mar 19, 2023
2310f0f
Add Framework for human readable folder structures
Mar 19, 2023
624eec9
Removed -h argument due to conflict
Mar 19, 2023
4ddff68
Game Folders / Files now respond to --human-folders
Mar 19, 2023
767895b
Update Readme.md to include new argument
Mar 19, 2023
ac09641
Remove -h from arg logic because it's not used and collides with help
Mar 19, 2023
65c2750
There was an issue preventing downloads of titles you owned that cont…
Mar 21, 2023
01dcd0b
Merge Changes from main
N64Core Mar 24, 2023
1ef1a87
PR #78 Post-Review Changes
N64Core Mar 30, 2023
7da7684
PR #78 Linting Fixes
N64Core Mar 30, 2023
2545e42
PR #78 More Linting Fixes
N64Core Mar 30, 2023
a40b518
PR #78 More Linting Fixes
N64Core Mar 30, 2023
d2f4c86
PR #78 More Linting Fixes
N64Core Mar 30, 2023
82cda72
PR #78 address first comment
N64Core Mar 30, 2023
b4d4a0e
PR #78 address second comment
N64Core Apr 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions itchiodl/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ def clean_path(path):
"""Cleans a path on windows"""
if sys.platform in ["win32", "cygwin", "msys"]:
path_clean = re.sub(r"[<>:|?*\"\/\\]", "-", path)
# This checks for strings that end in ... or similar, weird corner case that affects fewer than 0.1% of titles
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this an issue? I don't want the renaming function to be overzealous, which it seems to be heading towards

path_clean = re.sub(r'(.)[.]\1+$', "-", path_clean)
return path_clean
return path

Expand Down