Bugfix/free downloads issue #78
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ained free demo content Added key pair caching code to support faster checking of owned single downloads load_game was condensed as the ownership check no longer occurs inside it Key pair caching can also be used for issue Emersont1#67
Emersont1
requested changes
Mar 25, 2023
Emersont1
reviewed
Mar 30, 2023
Emersont1
reviewed
Apr 16, 2023
itchiodl/utils.py
Outdated
| @@ -41,6 +41,8 @@ def clean_path(path): | |||
| """Cleans a path on windows""" | |||
| if sys.platform in ["win32", "cygwin", "msys"]: | |||
| path_clean = re.sub(r"[<>:|?*\"\/\\]", "-", path) | |||
| # This checks for strings that end in ... or similar, weird corner case that affects fewer than 0.1% of titles | |||
There was a problem hiding this comment.
is this an issue? I don't want the renaming function to be overzealous, which it seems to be heading towards
Emersont1
reviewed
Apr 16, 2023
| self.downloads.append(d) | ||
| # This converts a null j.uploads into an empty dictionary and uses the safer .get accessor | ||
| if "uploads" in j: | ||
| j.update({"uploads": []}) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR effectively rewrites the load_game function and adds download key caching for faster single game downloads after the first one. The purpose of these changes is to fix an issue that would occur when an owned game possessed a free demo download, the result previously is that only the free demo content would be downloaded.
The caching of keys helps with this, but is not strictly necessary but will be useful for a full implementation of the feature requested by #67