[2186] Remove MacOS Support #2187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Now
Rixxan
added
code cleanup
Closed
C1701D
reviewed
Apr 5, 2024
C1701D
reviewed
Apr 5, 2024
C1701D
requested changes
Apr 5, 2024
Just makes it nicer to read.
C1701D
approved these changes
Apr 6, 2024
This was referenced Apr 12, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Development of Elite Dangerous on macOS ended over half a decade ago. Recent changes to the macOS NSSound API may have resulted in EDMC no longer functioning. There is no functional manner to play Elite on macOS natively, and known macOS users have reported using Wine and the distributed EXEs to utilize EDMC and Elite.
This removes all references to macOS from the code ("Darwin") and simplifies/deprecates functions, translations, and other works as relevant. This also has the added benefit of significantly simplifying some aspects of code which will make future changes much easier.
This should not significantly impact the user experience on any other platform. This will require a documentation update on the Wiki.
Type of change
How has this been tested?
Resolves #2186