[2186] Refine macOS Removal #2200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rixxan
added
bug
python
|
Also, I hate merge conflicts. All things in this PR are meant to replace/override the previous PR. |
|
Better branch exists for this. Deleting, will re-make. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous PR to remove macOS support (#2187) accidentally was a little too overzealous and removed the functionality added by #2183 by converting the usage of nb.Entry to ttk.Entry instead of the intended nb.EntryMenu.
nb.Entry usage still should be eliminated, but the alternative should be our menu class.
Also clarifies some side issues and details.
Resolves #2186
All other details of #2187 are still valid.