Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1133] Add ContextMenu Globally #2183

Merged
merged 4 commits into from
Apr 5, 2024

Conversation

Rixxan
Copy link
Contributor

@Rixxan Rixxan commented Mar 23, 2024

Description

Adds a context menu including Cut, Copy, and Paste options to all nb.Entry fields, primarily those in the config menu.

fcjGMblQ11

This has been tested to ensure that any secrets cannot be extracted by using this system. This also leverages existing nb systems, so legacy MacOS functionality will be maintained (though they will not get this new feature).

Additionally, contains a fix to a ctypes prototype function that could break on some source installs running using 64-bit Python (not currently officially supported) and updates some developmental dependencies.

Includes a fix for a rare bug when running from source under #1805

Finally, this PR also adds the Python Image Library (Pillow) (#1471, NoFoolLikeOne/EDMC-Screenshot#51)

Type of change

  • Enhancement
  • New Package

How Has This Been Tested?

  • Tested on developer's machine, and tested to ensure that functionality cannot be leveraged to extract secrets
  • Tested on multiple Entry fields with various input and output.

Resolves #1133, #1471, #2171

Related to #1805

@Rixxan Rixxan added enhancement python Pull requests that update Python code ui User Interface Ready for Review PRs ready for review and merge labels Mar 23, 2024
@Rixxan Rixxan added this to the 5.11.0 milestone Mar 23, 2024
@Rixxan Rixxan requested a review from C1701D March 23, 2024 21:02
@Rixxan Rixxan self-assigned this Mar 23, 2024
@Rixxan Rixxan linked an issue Mar 28, 2024 that may be closed by this pull request
@C1701D C1701D added Staged Feature Complete and in Testing for Next Release and removed Ready for Review PRs ready for review and merge Staged Feature Complete and in Testing for Next Release labels Mar 28, 2024
myNotebook.py Outdated Show resolved Hide resolved
@C1701D C1701D added the Ready for Review PRs ready for review and merge label Mar 28, 2024
@Rixxan Rixxan linked an issue Mar 28, 2024 that may be closed by this pull request
@Rixxan
Copy link
Contributor Author

Rixxan commented Mar 28, 2024

@NoFoolLikeOne I don't know if you still maintain EDMC-Screenshot or not, but this seems to have been a request that your plugin in particular used, and it seemed to simply be the best solution for our purposes here so hopefully it helps!

Copy link
Member

@C1701D C1701D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rixxan Rixxan merged commit 29c43cb into EDCD:develop Apr 5, 2024
1 check passed
@Rixxan Rixxan deleted the enhancement/1133/context-menu-Entry branch April 5, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement python Pull requests that update Python code Ready for Review PRs ready for review and merge ui User Interface
Projects
Status: Complete
2 participants