-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1133] Add ContextMenu Globally #2183
Merged
Rixxan
merged 4 commits into
EDCD:develop
from
HullSeals:enhancement/1133/context-menu-Entry
Apr 5, 2024
Merged
[1133] Add ContextMenu Globally #2183
Rixxan
merged 4 commits into
EDCD:develop
from
HullSeals:enhancement/1133/context-menu-Entry
Apr 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rixxan
added
enhancement
python
Pull requests that update Python code
ui
User Interface
Ready for Review
PRs ready for review and merge
labels
Mar 23, 2024
C1701D
added
Staged
Feature Complete and in Testing for Next Release
and removed
Ready for Review
PRs ready for review and merge
Staged
Feature Complete and in Testing for Next Release
labels
Mar 28, 2024
C1701D
reviewed
Mar 28, 2024
@NoFoolLikeOne I don't know if you still maintain EDMC-Screenshot or not, but this seems to have been a request that your plugin in particular used, and it seemed to simply be the best solution for our purposes here so hopefully it helps! |
C1701D
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Apr 12, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
python
Pull requests that update Python code
Ready for Review
PRs ready for review and merge
ui
User Interface
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a context menu including Cut, Copy, and Paste options to all nb.Entry fields, primarily those in the config menu.
This has been tested to ensure that any secrets cannot be extracted by using this system. This also leverages existing nb systems, so legacy MacOS functionality will be maintained (though they will not get this new feature).
Additionally, contains a fix to a ctypes prototype function that could break on some source installs running using 64-bit Python (not currently officially supported) and updates some developmental dependencies.
Includes a fix for a rare bug when running from source under #1805
Finally, this PR also adds the Python Image Library (Pillow) (#1471, NoFoolLikeOne/EDMC-Screenshot#51)
Type of change
How Has This Been Tested?
Resolves #1133, #1471, #2171
Related to #1805