-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EVA-3586 - Allow colon in chromosome names #248
Conversation
inc/vcf/error-odb.hpp
Outdated
@@ -1052,7 +1052,7 @@ namespace odb | |||
typedef | |||
sqlite::query_column< | |||
sqlite::value_traits< | |||
::size_t, | |||
long unsigned int, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change have been introduce by ragel transpiler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to plead ignorance on the size_t
to long unsigned int
change... but otherwise this looks fine.
Co-authored-by: April Shen <[email protected]>
Simply allows colon in chromosome names