Skip to content

Commit

Permalink
Merge pull request #248 from tcezard/relax_chrom_names
Browse files Browse the repository at this point in the history
EVA-3586 - Allow colon in chromosome names
  • Loading branch information
tcezard authored Jul 2, 2024
2 parents b1d7a46 + a426d63 commit 76b0d2b
Show file tree
Hide file tree
Showing 26 changed files with 4,304 additions and 3,224 deletions.
2 changes: 1 addition & 1 deletion inc/vcf/error.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ namespace ebi
using BodySectionError::BodySectionError;
ChromosomeBodyError() : ChromosomeBodyError{0} {}
ChromosomeBodyError(size_t line) : ChromosomeBodyError{line,
"Chromosome is not a string without colons or whitespaces, optionally wrapped with angle brackets (<>)"} { }
"Chromosome is not a string without whitespaces, optionally wrapped with angle brackets (<>)"} { }
virtual ~ChromosomeBodyError() override { }
virtual void apply_visitor(ErrorVisitor &visitor) override { visitor.visit(*this); }
};
Expand Down
9 changes: 1 addition & 8 deletions inc/vcf/file_structure.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -330,19 +330,12 @@ namespace ebi
void set_types();

/**
* Checks that chromosome does not contain colons or white-spaces
* Checks that chromosome does not contain white-spaces
*
* @throw ChromosomeBodyError
*/
void check_chromosome() const;

/**
* Checks that chromosome does not contain any colons
*
* @throw ChromosomeBodyError
*/
void check_chromosome_no_colons() const;

/**
* Checks that chromosome does not contain any white-spaces
*
Expand Down
Loading

0 comments on commit 76b0d2b

Please sign in to comment.