-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add page label info to page marker flags #330
Add page label info to page marker flags #330
Conversation
Add the info necessary to construct the labels when in GG1. Format is `[ImgNNN|Arabic|+1]` "Arabic" can be "Roman" "+1" can be "No Count" or a page number This version must be used in conjunction with a version of GG1 that has the added info - it won't work with older versions of GG1, like 1.6.2.
Two advantages of this version:
|
See equivalent edits in GG2 (PR DistributedProofreaders#330). Will not work with older versions of GG2. DistributedProofreaders/guiguts-py#330
Discovered during cross-testing that GG1 and GG2 do not join words split across page boundaries the same. GG1 places the page marker at the end of the word that was split. GG2 places the page marker where the split occurred. My understanding is that GG1's behavior is the expected behavior. One other difference that I don't know whether it matters: when I add page marker flags, they're added at the end of the line in GG1, and at the beginning of the line in GG2. |
Added issue #331 to tackle this - thanks! |
I believe this is caused by GG1 moving page marks to end of line during Page Sep Fixup, rather than any fault in GG1 or GG2 Page Marker Flag addition. No action necessary IMHO. |
See equivalent edits in GG2 (PR #330). Will not work with older versions of GG2. DistributedProofreaders/guiguts-py#330
Add the info necessary to construct the labels when in GG1. Format is
[ImgNNN|Arabic|+1]
"Arabic" can be "Roman"
"+1" can be "No Count" or a page number
This version must be used in conjunction with a version of GG1 that has the added info - it won't work with older versions of GG1, like 1.6.2.
GG1 PR#1308