Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add page label info to page marker flags #330

Merged

Conversation

windymilla
Copy link
Collaborator

@windymilla windymilla commented Jul 20, 2024

Add the info necessary to construct the labels when in GG1. Format is [ImgNNN|Arabic|+1]
"Arabic" can be "Roman"
"+1" can be "No Count" or a page number

This version must be used in conjunction with a version of GG1 that has the added info - it won't work with older versions of GG1, like 1.6.2.

GG1 PR#1308

Add the info necessary to construct the labels when in GG1.
Format is `[ImgNNN|Arabic|+1]`
"Arabic" can be "Roman"
"+1" can be "No Count" or a page number

This version must be used in conjunction with a version
of GG1 that has the added info - it won't work with older
versions of GG1, like 1.6.2.
@windymilla
Copy link
Collaborator Author

Two advantages of this version:

  1. You can delete the page flags as soon as you load into GG1 and work on it as much as you like, then add them back just before saving to transfer back to using GG2.
  2. The page numbering info is all transferred, not just the page break location.

windymilla added a commit to windymilla/guiguts that referenced this pull request Jul 20, 2024
See equivalent edits in GG2 (PR DistributedProofreaders#330). Will not work with
older versions of GG2.

DistributedProofreaders/guiguts-py#330
@windymilla windymilla requested a review from srjfoo July 20, 2024 19:56
@srjfoo
Copy link
Member

srjfoo commented Jul 20, 2024

Discovered during cross-testing that GG1 and GG2 do not join words split across page boundaries the same. GG1 places the page marker at the end of the word that was split. GG2 places the page marker where the split occurred. My understanding is that GG1's behavior is the expected behavior.

One other difference that I don't know whether it matters: when I add page marker flags, they're added at the end of the line in GG1, and at the beginning of the line in GG2.

@windymilla
Copy link
Collaborator Author

Discovered during cross-testing that GG1 and GG2 do not join words split across page boundaries the same. GG1 places the page marker at the end of the word that was split. GG2 places the page marker where the split occurred. My understanding is that GG1's behavior is the expected behavior.

Added issue #331 to tackle this - thanks!

@windymilla
Copy link
Collaborator Author

One other difference that I don't know whether it matters: when I add page marker flags, they're added at the end of the line in GG1, and at the beginning of the line in GG2.

I believe this is caused by GG1 moving page marks to end of line during Page Sep Fixup, rather than any fault in GG1 or GG2 Page Marker Flag addition. No action necessary IMHO.

@windymilla windymilla merged commit 709be86 into DistributedProofreaders:master Jul 23, 2024
1 check passed
@windymilla windymilla deleted the page-markers-2 branch July 23, 2024 12:58
windymilla added a commit to DistributedProofreaders/guiguts that referenced this pull request Jul 23, 2024
See equivalent edits in GG2 (PR #330). Will not work with
older versions of GG2.

DistributedProofreaders/guiguts-py#330
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants