Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop Page Sep Fixup leaving page breaks mid-word #333

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

windymilla
Copy link
Collaborator

Instead of joining the lines and then insert a newline after the end of the joined word, cut the second part of the word and paste it on the end of the first part. This preserves the page break at the start of the
second line.

Instead of joining the lines and then insert a newline
after the end of the joined word, cut the second part
of the word and paste it on the end of the first part.
This preserves the page break at the start of the
second line.
@windymilla windymilla requested a review from srjfoo July 21, 2024 20:49
@srjfoo
Copy link
Member

srjfoo commented Jul 23, 2024

On this one, I've been stepping through a separator at a time, so I actually spotted this. I expect that it's this way in #330 also, so I don't know if you want to fix it there, or punt it (or tell me, "No, no, Sharon, you did it all wrong!").

In this situation, where there are two consecutive page separators because the only thing on that page was an illustration mid-para that had already been moved:

image

This is what happens:

image

@windymilla
Copy link
Collaborator Author

where there are two consecutive page separators...

I've added an issue for this as it's not related - GG1 has a related bug, although it (just) copes with this exact situation. I'm not going to change GG1, but I will make GG2 cope with consecutive page seps.

If you don't have any other concerns, this can be approved, and I will tackle the other issue separately - thanks.

@windymilla windymilla linked an issue Jul 23, 2024 that may be closed by this pull request
1. Cope with consecutive page seps better
2. Handle closed & re-opened block/nowrap markup
in the auto and join actions.
3. Improve handling of multiple close/reopen markup.
@windymilla windymilla merged commit 6501d8c into DistributedProofreaders:master Jul 25, 2024
1 check passed
@windymilla windymilla deleted the page-seps branch July 25, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page Separator Fixup is leaving page breaks mid-word
2 participants