#21: Refactored repo for consistency #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucifercr07
approved these changes
Oct 4, 2024
10 tasks
yashbudhia
pushed a commit
to yashbudhia/playground-mono
that referenced
this pull request
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task List
Use the word DiceDB and not Dice everywhere. There are variable and config places where the word Dice is used.
Rename config
REQUEST_LIMITtoREQUEST_LIMIT_PER_MIN.Rename config
REQUEST_WINDOWtoREQUEST_WINDOW_SEC.Remove package
internals/cmds, and move the struct tohttpServer.go.Rename the endpoint
/clito/shell/exec. (will make the change in the FE repo too.)Standardize all error messages with respect to casing. Change all to lowercase.
Change filename:
server/httpServer.go->server/http.go.Update the
errorResponsefunction to use JSON marshalling instead of string formatting.Use slog everywhere instead of a mix of
logandslog.Rename file
pkg/util/helpers.go->util/httpHelper.go.