Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor repo for consistency #21

Closed
10 tasks
lucifercr07 opened this issue Oct 3, 2024 · 3 comments
Closed
10 tasks

Refactor repo for consistency #21

lucifercr07 opened this issue Oct 3, 2024 · 3 comments
Assignees

Comments

@lucifercr07
Copy link
Contributor

Fix below changes as part of playground-mono repo:

  • Use the word DiceDB and not Dice, every where, there are variable and config places where the word Dice is used.
  • Rename config “REQUEST_LIMIT” should be “REQUEST_LIMIT_PER_MIN”
  • Rename config “REQUEST_WINDOW” should be “REQUEST_WINDOW_SEC”
  • Remove package internals/cmds, we can move that struct to httpServer.go
  • Rename the endpoint as /cli, let’s call it /shell/exec. (Remember to add Frontend changes for the same)
  • All errors to be standardized w.r.t casing. We shall change everything to be lowercase.
  • Change filename: server/httpServer.go -> server/http.go
  • Update “errorResponse” function to JSON marshal and not string format.
  • Currently log and slog are both being used, let’s just use slog everywhere.
  • Rename pkg/util/helpers.go -> util/httpHelper.go
@rishavvajpayee
Copy link
Contributor

Hey @lucifercr07 i can take this up

@lucifercr07
Copy link
Contributor Author

@rishavvajpayee assigned, thanks for contributing.

rishavvajpayee added a commit to rishavvajpayee/playground-mono that referenced this issue Oct 4, 2024
rishavvajpayee added a commit to rishavvajpayee/playground-mono that referenced this issue Oct 4, 2024
@lucifercr07
Copy link
Contributor Author

Closing, merged as part of #24

yashbudhia pushed a commit to yashbudhia/playground-mono that referenced this issue Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants