Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update translations #110

Merged
merged 4 commits into from
Nov 13, 2024
Merged

update translations #110

merged 4 commits into from
Nov 13, 2024

Conversation

chris48s
Copy link
Member

This PR is here mostly as a reminder.

In both #108 and #109 I am making changes that affect the translations file.

My instinct was to run make i18n_extract on each branch and commit the changes to the generate .po files, but I found that the translations weren't up to date so a bunch of other stuff spewed out. This commit is the result of running make i18n_extract on main.

Just to reduce the merge conflicts, I'm going to say we review those 2 PRs as they stand and then I'll rebase this PR on main and merge the result.

How do we go about getting translations updated for this project?

@chris48s chris48s changed the title WIP update translations update translations Nov 4, 2024
@chris48s chris48s marked this pull request as ready for review November 4, 2024 11:57
@chris48s chris48s requested a review from symroe November 4, 2024 11:57
@chris48s
Copy link
Member Author

chris48s commented Nov 4, 2024

OK. This PR now accounts for everything on main

@symroe
Copy link
Member

symroe commented Nov 4, 2024

@chris48s there's a translation service we've used in the past form the Welsh Gov. Hello blod? @pmk01 will know the details.

@chris48s
Copy link
Member Author

chris48s commented Nov 4, 2024

OK. So it is our responsibility to send text off to the translators, get it back and update the po files?

@chris48s
Copy link
Member Author

chris48s commented Nov 7, 2024

I've updated a couple of translations here, but the decision from the EC is we don't need to translate the City of London stuff since it is text that is only shown to users in England.

@chris48s chris48s merged commit 1990a95 into main Nov 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants