Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for overrideable configuration settings such as feature flags. #58

Merged
merged 4 commits into from
Apr 26, 2024

Conversation

brettle
Copy link
Member

@brettle brettle commented Apr 25, 2024

Also modify the CI build task to fail if any settings are overridden and put the overriden settings to the dashboard and the terminal.

Includes unit tests.

Tested in simulator.

…lags.

Also modify the CI build task to fail if any settings are overridden.
@brettle brettle requested a review from a team as a code owner April 25, 2024 22:01
@brettle brettle enabled auto-merge April 25, 2024 22:01
brettle and others added 3 commits April 25, 2024 15:08
Also add some clarifying comments and use a better test name for the test that fails when a setting is overriden.
Copy link
Contributor

@FriedLongJohns FriedLongJohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MONKEY MONKEY

@brettle brettle merged commit 2b7f1fa into master Apr 26, 2024
1 check passed
@brettle brettle deleted the add-config-support branch April 26, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants