Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding gobwords and other cleanup #52

Merged
merged 5 commits into from
Jan 24, 2024
Merged

adding gobwords and other cleanup #52

merged 5 commits into from
Jan 24, 2024

Conversation

cswatt
Copy link
Contributor

@cswatt cswatt commented Dec 5, 2023

What does this PR do?

Motivation

Release

  • YES, this PR requires a release
  • NO, this PR doesn't need a release

Additional Notes


Release checklist

  • Create zip files for EACH style folder.
  • Attach the zip files when creating a release.

@cswatt cswatt added the DO NOT MERGE Don't merge this yet label Dec 5, 2023
@cswatt cswatt requested a review from a team as a code owner December 5, 2023 00:10
@cswatt cswatt added editorial review Waiting on a more in-depth review and removed DO NOT MERGE Don't merge this yet labels Dec 7, 2023
@cswatt cswatt changed the title [WIP] adding gobwords and other cleanup adding gobwords and other cleanup Dec 8, 2023
@cswatt cswatt mentioned this pull request Dec 8, 2023
4 tasks
@cswatt
Copy link
Contributor Author

cswatt commented Dec 8, 2023

includes updates from #53

Copy link
Contributor

@hestonhoffman hestonhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions, but this LGTM

styles/Datadog/autodiscovery.yml Outdated Show resolved Hide resolved
extends: existence
message: "Format times as 'HOUR:MINUTE a.m.' or HOUR:MINUTE p.m.' instead of '%s'."
link: "https://datadoghq.atlassian.net/wiki/spaces/WRIT/pages/2732523547/Style+guide#%s"
level: error
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to error?

styles/Datadog/time.yml Outdated Show resolved Hide resolved
@cswatt cswatt merged commit c4bac08 into main Jan 24, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial review Waiting on a more in-depth review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants