shfmt pre-commit

[PLangowski]

No description provided.

[PLangowski]

I set the indent to 4 spaces, although I think 2 spaces also look okay.

[macpijan]

although I think 2 spaces also look okay.

Then we can try to go with 2 spaces, following https://google.github.io/styleguide/shellguide.html as well. Likely it will also trigger less changes?

[PLangowski]

@macpijan done

[macpijan]

Thanks, LGTM.

Would it be a problem for your UEFI capsule changes @DaniilKl if we merge this?
If so, we can hold off with merging.

[DaniilKl]

@macpijan, yep, definitely there will be some rebasing, could you please merge it after QEMU/Capsule Update?

[macpijan]

Sure, I guess we can run shfmt again after we merge capsule PR.

[m-iwanicki]

@PLangowski QEMU/capsule update has been merged, are you going to rebase this PR?

[PLangowski]

rebased

[m-iwanicki]

Looks good. Not sure how much I like >"$file" as I always added space unless it's 2>&1 type redirect but otherwise I think it's great addition.

[m-iwanicki]

Wrong button I wanted to approve

[m-iwanicki]

@PLangowski just noticed, shftm in pre-commit doesn't fix files without .sh suffix. shftm used manually installed from dnf:

# dnf list --installed shfmt
Installed packages
shfmt.x86_64 3.7.0-5.fc41 fedora

fixes any file I point at it.
Can you check if this is fixable or maybe we should add suffix to all scripts?

[DaniilKl]

Can you check if this is fixable or maybe we should add suffix to all scripts?

If you add the suffix to all scripts - make sure to check everything that depends on the scripts and add suffixes there as well.

[m-iwanicki]

@PLangowski Probably in Makefile. Install script without extension so we don't have to make changes in scripts