-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Qemu adn UEFI Capsule Update support #26
Conversation
@macpijan, thought it is not a part of this PR, I have a question about EC firmware installation process. Currently in (...)
if [ "$HAVE_EC" == "true" ]; then
echo "Checking for Open Source Embedded Controller firmware"
$DASHARO_ECTOOL info >> $ERR_LOG_FILE 2>&1
if [ $? -eq 0 ]; then
echo "Device has already Open Source Embedded Controller firmware, do not flash EC..."
else
_ec_fw_version=$($FLASHROM -p "$PROGRAMMER_EC" ${FLASH_CHIP_SELECT} | grep "Mainboard EC Version" | tr -d ' ' | cut -d ':' -f 2)
if [ "$_ec_fw_version" != "$COMPATIBLE_EC_FW_VERSION" ]; then
print_warning "EC version: $_ec_fw_version is not supported, update required"
install_ec
fi
fi
fi
(...) IIUC, we want EC firmware version to match |
If a device already has open-source EC, then it most likely already has Dasharo as well, and the |
It is.
Ok then, but nobody stops a user with Dasharo installed to choose |
If Dasharo is displayed, |
My bad, have forgotten about it. |
56449a3
to
82aa244
Compare
82aa244
to
2309e4f
Compare
2309e4f
to
c5cc9d4
Compare
4c31e38
to
45c05be
Compare
6327fbb
to
761536a
Compare
For more inf. check Dasharo/open-source-firmware-validation#333 Signed-off-by: Daniil Klimuk <[email protected]>
Signed-off-by: Daniil Klimuk <[email protected]>
This warning serves as a checkpoint in tests in Dasharo/OSFV repo, it was unconvenient to have different warnings all other dasharo-deploy script, so this commit brings it to one format. Signed-off-by: Daniil Klimuk <[email protected]>
Reviewed-by: Michał Iwanicki <[email protected]> Signed-off-by: Daniil Klimuk <[email protected]>
Reviewed-by: Michał Iwanicki <[email protected]> Signed-off-by: Daniil Klimuk <[email protected]>
Reviewed-by: Michał Iwanicki <[email protected]> Signed-off-by: Daniil Klimuk <[email protected]>
Reviewed-by: Michał Iwanicki <[email protected]> Signed-off-by: Daniil Klimuk <[email protected]>
Reviewed-by: Michał Iwanicki <[email protected]> Signed-off-by: Daniil Klimuk <[email protected]>
flashrom does not support QEMU and fails every time. I have not found a better way to handle it, but we should not place hardwere related configs all around the code. Signed-off-by: Daniil Klimuk <[email protected]>
Signed-off-by: Daniil Klimuk <[email protected]>
Signed-off-by: Daniil Klimuk <[email protected]>
Signed-off-by: Daniil Klimuk <[email protected]>
Signed-off-by: Daniil Klimuk <[email protected]>
Signed-off-by: Daniil Klimuk <[email protected]>
Signed-off-by: Daniil Klimuk <[email protected]>
163b50e
to
3f5a23b
Compare
Signed-off-by: Daniil Klimuk <[email protected]>
Signed-off-by: Daniil Klimuk <[email protected]>
Signed-off-by: Daniil Klimuk <[email protected]>
b9140a7
to
b3a9ac8
Compare
Signed-off-by: Daniil Klimuk <[email protected]>
…rver login_to_dpp_server should only try to login, the decision to print warning or not should be done outside this function basing on the output of this function. Otherwise every time the function is being called the warning could be printed too, which is not always wanted. Signed-off-by: Daniil Klimuk <[email protected]>
Signed-off-by: Daniil Klimuk <[email protected]>
8758874
to
fd823a9
Compare
Forgot to delete one WIP commit. Deleted now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. Will need to be tested before release
This PR adds support for Qemu so to be able to test DTS and its features more easily. Additionally, this PR adds support for Dasharo firmware updates provided via UEFI capsules.