-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Bootstrap 5 & realign themes #3506
base: main
Are you sure you want to change the base?
Upgrade to Bootstrap 5 & realign themes #3506
Conversation
…pgraded to Bootstrap 5.3.3
… side of its label fix
package.json
Outdated
"@ng-dynamic-forms/core": "^16.0.0", | ||
"@ng-dynamic-forms/ui-ng-bootstrap": "^16.0.0", | ||
"@ngrx/effects": "^17.1.1", | ||
"@ngrx/router-store": "^17.1.1", | ||
"@ngrx/store": "^17.1.1", | ||
"@ngx-translate/core": "^14.0.0", | ||
"@nicky-lenaers/ngx-scroll-to": "^14.0.0", | ||
"@popperjs/core": "^2.9.2", | ||
"@types/grecaptcha": "^3.0.4", | ||
"angular-idle-preload": "3.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Wout-atmire : Please don't add @types/grecaptcha
back in the main dependencies. This was moved to devDependencies
in #3553, and you are reverting those changes.
You've also reverted the removal of angular-idle-preload
, which is no longer used in DSpace (again this was removed in #3553).
Hi @Wout-atmire, |
…rd-dspace-themes-after-bootstrap-5-upgrade-9.0
Hi @Wout-atmire, |
…rd-dspace-themes-after-bootstrap-5-upgrade-9.0
Hi @Wout-atmire, |
…andard-dspace-themes-after-bootstrap-5-upgrade-9.0
…lign-standard-dspace-themes-after-bootstrap-5-upgrade-9.0
Hi @Wout-atmire, |
References
Description
This PR aims to change the Bootstrap version of DSpace from Bootstrap version 4 to Bootstrap version 5 because version 4 is out of date. This version upgrade includes the required visual changes to maintain the same look as the DSpace version with Bootstrap 4.
Instructions for Reviewers
List of changes in this PR:
@ng-bootstrap/ng-bootstrap
to version^12.0.0
andbootstrap
to version^5.3
text-right
totext-end
,ml-4
toms-4
, ...)To test this you can start a local Angular instance in combination with the REST of host:
demo.dspace.org
. You can then compare it in another browser tab with DSpace that still uses Bootstrap 4https://demo.dspace.org
.Note that we deliberately left in some style changes:
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
main
branch of code (unless it is a backport or is fixing an issue specific to an older branch).Reason: This is an upgrade for a major dependency and thus it affects a lot of code.
npm run lint
npm run check-circ-deps
)package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.