Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to angular v18 #3717

Open
wants to merge 99 commits into
base: main
Choose a base branch
from

Conversation

AAwouters
Copy link
Contributor

@AAwouters AAwouters commented Dec 6, 2024

References

This branch continues on the work of #3506 which makes it look like this PR contains a lot more commits than it actually does. This compare view shows only the commits that belong to this PR.

Description

Updates Angular to version 18.
Dependencies related to Angular are also updated.

Instructions for Reviewers

This PR does not include any new functionality. Test DSpace as you usually would.

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

LotteHofstede and others added 30 commits August 28, 2024 13:26
@AAwouters AAwouters marked this pull request as ready for review December 6, 2024 08:15
@tdonohue tdonohue added dependencies Pull requests that update a dependency file high priority labels Dec 6, 2024
@tdonohue tdonohue added this to the 9.0 milestone Dec 6, 2024
Copy link

Hi @AAwouters,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file high priority merge conflict
Projects
Status: 🙋 Needs Reviewers Assigned
Development

Successfully merging this pull request may close these issues.

Upgrade to Angular 18
5 participants