Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Port dspace-8_x] Add orcid icon with tooltip #3345

Open
wants to merge 1 commit into
base: dspace-8_x
Choose a base branch
from

Conversation

AndreaBarbasso
Copy link
Contributor

References

Description

A new component has been created and added to the ds-person-item-metadata-list-element component template. This component shows the ORCID logo and a tooltip on hovering shows the ORCID of the person.

Instructions for Reviewers

You can see the ORCID logo in a Publication page with authors listed.

In order to show the ORCID logo, an author should have at least the person.identifier.orcid metadata set. In this case, the logo is shown with a greyscale filter and a tooltip shows the ORCID with an (unconfirmed) clause.

image

If the author also has the dspace.orcid.authenticated metadata value, the logo is shown in full color and the tooltip has no (unconfirmed) clause.

image

List of changes in this PR:

  • Created orcid-badge-and-tooltip component;
  • Included said component in the ds-person-item-metadata-list-element component template;

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@AndreaBarbasso AndreaBarbasso marked this pull request as ready for review September 25, 2024 09:16
@tdonohue tdonohue added identifiers: ORCID integration: ORCID Related to integration with ORCID identifier system labels Sep 26, 2024
@tdonohue tdonohue changed the title Add orcid icon with tooltip [8.x] [Port dspace-8_x] Add orcid icon with tooltip Sep 26, 2024
@tdonohue tdonohue mentioned this pull request Sep 26, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
identifiers: ORCID integration: ORCID Related to integration with ORCID identifier system
Projects
Status: 🙋 Needs Reviewers Assigned
Development

Successfully merging this pull request may close these issues.

2 participants