Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes Author ORCID iDs should be displayed on work landing pages out of the box (and noted as either authenticated or unauthenticated) DSpace#9086
dspace-8_x version: [Port dspace-8_x] Add orcid icon with tooltip #3345
dspace-7_x version: [Port dspace-7_x] Add orcid icon with tooltip #3346
Description
A new component has been created and added to the
ds-person-item-metadata-list-element
component template. This component shows the ORCID logo and a tooltip on hovering shows the ORCID of the person.Instructions for Reviewers
You can see the ORCID logo in a Publication page with authors listed.
In order to show the ORCID logo, an author should have at least the
person.identifier.orcid
metadata set. In this case, the logo is shown with a greyscale filter and a tooltip shows the ORCID with an(unconfirmed)
clause.If the author also has the
dspace.orcid.authenticated
metadata value, the logo is shown in full color and the tooltip has no(unconfirmed)
clause.List of changes in this PR:
orcid-badge-and-tooltip
component;ds-person-item-metadata-list-element
component template;Checklist
main
branch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lint
npm run check-circ-deps
)package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.