Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Accessibility cookie settings #3328

Merged

Conversation

Andrea-Guevara
Copy link
Contributor

@Andrea-Guevara Andrea-Guevara commented Sep 13, 2024

References

Description

Adding and changing some classes in the global scss to make the cookie settings more accessible.

Instructions for Reviewers

List of changes in this PR:

  • Added the variable "--very-dark-cyan" in _custom_variables.scss.
  • Removed the variable ".cm-btn.cm-btn-success.cm-btn-accept-all" and its styling as it was no longer needed.
  • Styled the "Accept all" button by overwriting the style of the ".klaro .cookie-modal .cm-btn.cm-btn-success.cm-btn-accept-all" variables.
  • Added "text-decoration: underline;" to the anchors.
  • Changed the color of some informational texts, which were previously gray and are now lighter to improve contrast.
  • Changed the color of the "Save" button by overwriting the styling of the variables: .klaro .cookie-modal .cm-btn.cm-btn-info.

To reproduce:

  1. Visit a DSpace repository in an anonymous browser.
  2. Klaro cookie popup should appear. Click on "Customize" to bring up the screen above
  3. Expand all sections on that screen.
  4. Run an accessibility scanner (WAVE or "axe DevTools) and check that the accessibility test is positive.

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release accessibility bug labels Sep 16, 2024
@tdonohue tdonohue self-requested a review September 16, 2024 21:29
@tdonohue tdonohue added the 1 APPROVAL pull request only requires a single approval to merge label Sep 16, 2024
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @Andrea-Guevara ! Finally got back to testing this, and I've verified this solves the color contrast issues with the Klaro cookie settings in 8.x. Merging this for 8.1, and auto-backporting to 7.6.3.

@tdonohue tdonohue added this to the 8.1 milestone Nov 8, 2024
@tdonohue tdonohue merged commit 65a4099 into DSpace:dspace-8_x Nov 8, 2024
13 checks passed
@dspace-bot
Copy link
Contributor

Backport failed for dspace-7_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-7_x
git worktree add -d .worktree/backport-3328-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-3328-to-dspace-7_x
git switch --create backport-3328-to-dspace-7_x
git cherry-pick -x 74c52bc5abf7474e11a6f924e40b071cad3b19da

@tdonohue
Copy link
Member

tdonohue commented Nov 8, 2024

Manually ported to 7.x in #3627

@tdonohue tdonohue removed the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge accessibility bug
Projects
Development

Successfully merging this pull request may close these issues.

3 participants