-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.x] Accessibility cookie settings #3140
Conversation
…e cookie settings more accessible
NOTE: it's possible this PR may have overlap/conflicts with #3199. We've realized in today's Developers Meeting that migrating our cookie consent form to Orejime might fix (or partially fix) the same accessibility issues as this ticket. This is because Orejime is a fork of Klaro which was created to fix accessibility issues in Klaro. So, anyone reviewing/testing this PR may want to also compare it to #3199. We need to determine if both PRs are necessary, or if migrating to Orejime will fix the issues we've had with accessibility in Klaro. |
2586c55
to
d0c8f03
Compare
Per my prior comment, I've realized we may still want to apply this small PR to 8.x and 7.x to fix accessibility in Klaro for those releases of DSpace. However, it should not be applied to 9.0, as #3199 will migrate us to using Orejime for 9.0 Could you update this PR @Andrea-Guevara to apply to |
Good afternoon @tdonohue! I didn't quite understand what you asked me, or even if you asked me anything haha. Is it to make the PR from a branch in dspace version 8? |
@Andrea-Guevara : I was asking if you could change this PR to be against the But, in the case of this PR, we cannot merge this one into However, if we could change this PR to be sent to the If this still doesn't make sense, we can probably apply this directly to |
Closing as this is replaced by #3328, as we've decided this should only be merged to 8.x and 7.x. |
References
Description
Adding and changing some classes in the global scss to make the cookie settings more accessible.
Instructions for Reviewers
List of changes in this PR:
Checklist