Coar Notify Integration

[frabacche]

Description

Quality Assurance Events and LDN Message Protocol.

Based on these old Pull Requests:

• contract: Rest contracts for qaevents, qatopics and qasources endpoints RestContract#181
• backend: Add a correction service to dspace to enhance the data quality (was Enrich local data via the OpenAIRE Graph) DSpace#8184
• frontend: Enrich local data via the OpenAIRE Graph #1562

Related to new Pull Requests:

• contract: Coar Notify Integration RestContract#249
• backend: Coar Notify Integration DSpace#9218

Continues on:

• backend: Coar Notify Integration - Administer/Log  DSpace#9268
• frontend: Coar Notify Integration - Administer/Log #2751
• contract: Coar Notify Integration - Administer/Log RestContract#251

Instructions for Reviewers

Technical implementations documented here : https://wiki.lyrasis.org/pages/viewpage.action?pageId=319815713

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using yarn lint
• My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[github-actions]

Hi @frabacche,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

[github-actions]

Hi @frabacche,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

[github-actions]

Hi @frabacche,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

[tdonohue]

@frabacche or @FrancescoMolinaro : please rebase this so that it no longer has merge conflicts so that it can be tested again. (I just added this same note to the backend PR as well)

[tdonohue]

@frabacche and @FrancescoMolinaro: I gave this a code review today. It appears all my prior feedback is addressed. However, I'm unable to test or merge this until the merge conflict is resolved.

[tdonohue]

@frabacche & @FrancescoMolinaro : I'm still testing this but found a small bug:

If I disable this feature via ldn.enabled = false and start the UI in prod mode (yarn build:prod; yarn serve:ssr), then every page reload results in a minor error in your Browser's DevTools:

ERROR TypeError: You provided 'undefined' where a stream was expected. You can provide an Observable, Promise, ReadableStream, Array, AsyncIterable, or Iterable.
    at t (main.e95be47509bc96ea.js:1:1789880)
    at v (main.e95be47509bc96ea.js:1:1769810)
    at l.subscribe.g (main.e95be47509bc96ea.js:1:1780091)
    at o._next (main.e95be47509bc96ea.js:1:1772359)
    at o.next (main.e95be47509bc96ea.js:1:1761159)
    at main.e95be47509bc96ea.js:1:1776332
    at o._next (main.e95be47509bc96ea.js:1:1772359)
    at o.next (main.e95be47509bc96ea.js:1:1761159)
    at subscribe.h (main.e95be47509bc96ea.js:1:1780127)
    at o._next (main.e95be47509bc96ea.js:1:1772359)

This error can also be found in the SSR logs with a bit more detail:

ERROR TypeError: You provided 'undefined' where a stream was expected. You can provide an Observable, Promise, ReadableStream, Array, AsyncIterable, or Iterable.
    at Object.createInvalidObservableTypeError (C:\dspace-angular\dist\server\main.js:7:1997485)
    at Object.innerFrom (C:\dspace-angular\dist\server\main.js:7:1828015)
    at C:\dspace-angular\dist\server\main.js:7:1920404

It appears to only occur when this feature is disabled. No similar error appears when ldn.enabled = true.

I'm still testing, but wanted to report this immediately. If it turns out to be the only error, I may still approve this & create a bug ticket for you to resolve in the next set of COAR Notify PRs.

[tdonohue]

There are 4 keys in a row here that are duplicates. The keys on 6165-6171 can be removed because they already appear in this file.

[tdonohue]

👍 Thanks @frabacche and @FrancescoMolinaro ! My prior feedback has been addressed. However there are two very minor issues that remain. In order to move this along & free up the other PRs, I'm going to merge this as-is and log a bug ticket to fix the two remaining issues.

The two remaining issues are:

1. An error occurs when this feature is disabled. See Coar Notify Integration #2681 (comment)
2. Duplicate i18n keys exist. The ones added by this PR should be removed as they override the changes made in WITHDRAW / REINSTATE requests for an item #2759 . See Coar Notify Integration #2681 (review)

[tdonohue]

Added a bug ticket which must be resolved in follow-up work: #2842. Assigned to @frabacche