Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor bugs with COAR Notify initial implementation #2842

Closed
tdonohue opened this issue Feb 29, 2024 · 2 comments · Fixed by #2856
Closed

Minor bugs with COAR Notify initial implementation #2842

tdonohue opened this issue Feb 29, 2024 · 2 comments · Fixed by #2856
Assignees
@frabacche
Labels
bug claimed: 4Science 4Science team is working on this issue & will contribute back high priority integration: COAR Notify / LDN Related to Linked Data Notifications (LDN) or COAR Notify services
Milestone
8.0

Comments

@tdonohue
Copy link
Member

tdonohue commented Feb 29, 2024 •
edited
Loading

Describe the bug
Two minor bugs were not yet addressed in the initial COAR Notify PR #2681

  1. An error occurs in the UI when ldn.enable=false is set. See Coar Notify Integration #2681 (comment) (Partially fixed by Coar Notify Integration - Administer/Log #2751)
  2. Duplicate i18n keys exist. The ones added by this PR should be removed as they override the changes made in WITHDRAW / REINSTATE requests for an item #2759 . See Coar Notify Integration #2681 (review) (Fixed by Coar Notify Integration - Administer/Log #2751)

These issues must be resolved in a small PR or in the follow-up work in #2751
@tdonohue tdonohue added bug high priority claimed: 4Science 4Science team is working on this issue & will contribute back labels Feb 29, 2024
@tdonohue tdonohue added this to the 8.0 milestone Feb 29, 2024
@tdonohue tdonohue moved this from 📋 To Do to 🏗 In Progress in DSpace 8.0 Release Feb 29, 2024
@tdonohue tdonohue mentioned this issue Feb 29, 2024
Merged
8 tasks
@tdonohue tdonohue added the integration: COAR Notify / LDN Related to Linked Data Notifications (LDN) or COAR Notify services label Feb 29, 2024
@tdonohue tdonohue mentioned this issue Feb 29, 2024
Merged
8 tasks
FrancescoMolinaro added a commit to 4Science/dspace-angular that referenced this issue Mar 1, 2024
@FrancescoMolinaro
resolve issue DSpace#2842
b94167a
@tdonohue
Copy link
Member Author

tdonohue commented Mar 4, 2024

UPDATE: #2751 solved most of these bugs. However, the TypeError that occurs when ldn.enable=false still occurs only on the Item view page. See this comment for details: #2751 (review)

Once that TypeError on the Item view page is solved, this bug ticket can be closed.

This was referenced Mar 5, 2024
Closed
Merged
@frabacche
Copy link
Contributor

@tdonohue pr linked to this issue at here.

@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in DSpace 8.0 Release Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frabacche frabacche

Labels
bug claimed: 4Science 4Science team is working on this issue & will contribute back high priority integration: COAR Notify / LDN Related to Linked Data Notifications (LDN) or COAR Notify services
Projects
No open projects
DSpace 8.0 Release
Status: ✅ Done
Milestone
8.0
Development

Successfully merging a pull request may close this issue.

fix 'undefined' error on anonymous item page landing 4Science/dspace-angular
2 participants
@tdonohue @frabacche