Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docker] Refactor to simply use the reusable-docker-build.yml from DSpace/DSpace. #2666

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

tdonohue
Copy link
Member

Description

In DSpace/DSpace#9213 a new reusable-docker-build.yml was created for DSpace/DSpace at https://github.com/DSpace/DSpace/blob/main/.github/workflows/reusable-docker-build.yml

This was based on refactoring in dspace-angular in #2644. Therefore, as a final refactor for dspace-angular, we can easily update the docker.yml script to use that reusable-docker-build.yml.

This PR makes that refactor. A similar PR will be needed for dspace-7_x to use the dspace-7_x version of reusable-docker-build.yml

@tdonohue tdonohue added code task 1 APPROVAL pull request only requires a single approval to merge backend: Docker related to DSpace deployment via Docker labels Nov 28, 2023
@tdonohue tdonohue added this to the 8.0 milestone Nov 28, 2023
@tdonohue
Copy link
Member Author

Ported to dspace-7_x in #2667

@tdonohue tdonohue merged commit 474b70b into DSpace:main Nov 29, 2023
13 checks passed
@tdonohue tdonohue deleted the use_reusable_docker_build branch November 29, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge backend: Docker related to DSpace deployment via Docker code task
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

1 participant