Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up Docker image build fix. Fix directory structure for latest-dist digests #2650

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

tdonohue
Copy link
Member

References

Description

This is a minor fix to the directory structure of where latest-dist digests are stored. This fix is necessary so that the new matrix process works properly... without it, the latest-dist digests cannot be found, resulting in issues in DockerHub.

Instructions for Reviewers

  • Will be merged immediately as this is only possible to test after the PR is merged. I've triple-checked my work though, so I feel this should finally get these parallel Docker image builds working properly

Once this is succeeding on main, all these changes will be backported to dspace-7_x.

@tdonohue tdonohue added bug code task 1 APPROVAL pull request only requires a single approval to merge backend: Docker related to DSpace deployment via Docker labels Nov 17, 2023
@tdonohue tdonohue added this to the 8.0 milestone Nov 17, 2023
@tdonohue tdonohue changed the title Follow-up Docker image build fix. Fix directory structure for latest-dist digests Follow-up Docker image build fix. Fix directory structure for latest-dist digests Nov 17, 2023
@tdonohue
Copy link
Member Author

The code changes in the docker.yml file made in this PR are only triggered when a PR is merged. Therefore, I'm merging this immediately as it's (unfortunately) the only way to test these changes fix the bug.

@tdonohue tdonohue merged commit 0d7d9f1 into DSpace:main Nov 17, 2023
9 checks passed
@tdonohue tdonohue deleted the fix_docker_manifests_again branch November 17, 2023 18:05
@tdonohue
Copy link
Member Author

Ported to dspace-7_x in #2655

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge backend: Docker related to DSpace deployment via Docker bug code task
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

1 participant